git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Updates to the previous mergetool patches

From
Charles Bailey <charles@hashpling.org>
Date
Dec 12, 2008, 21:48 UTC
Message-ID
<1229118521-22923-1-git-send-email-charles@hashpling.org>

These two patches go on top of 682b451f and replace the 'DONTMERGE' commit: 09b511016. If it would be easier if I cooked these in a different way then let me know.

I've implemented a replacement for the "keep going" option which is now to prompt after a failed merge to see if the user wants to continue merging the remaining paths. This gets rid of a need for an option of configuration option.

I haven't implemented any change to the logic as to whether to pause before invoking the merge tool based on which merge tool is being used.

The added tests for the return status of the merge are slightly less neat than I would have liked, but I think are necessary. I test after invoking the merge tool to make sure that the "roll-up" status is correct, and before invoking the next tool to see if the user wants to continue despite the failure of the previous merge.

Only testing after the merge tool invocation can end up with a "do you want to continue" before mergetool has determined that there are, in fact, no more files to merge. Only testing before the merge means that the status of the last merge doesn't contribute to the script's return value. I don't know how many people rely on the return value of git mergetool, but why not keep it consistent?

The second patch makes optional the retention of temporary files on a failed merge optional. It seperates out the behaviour change that I'd forgotten I'd left in the previous version of the "-k" patch.

Next: Charles Bailey
Message 1 of 4 in “Updates to the previous mergetool patches”
  1. Charles BaileyDec 12, 2008
  2. 1/2 mergetool: Add prompt to continue after failing to merge a fileCharles Bailey, Dec 12, 2008
  3. 2/2 mergetool: Don't keep temporary merge files unless told toCharles Bailey, Dec 12, 2008
  4. Jakub NarebskiDec 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.