git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 0/6] RawParseUtil improvements

From
Shawn O. Pearce <spearce@spearce.org>
Date
Dec 10, 2008, 22:05 UTC
Message-ID
<1228946751-12708-1-git-send-email-spearce@spearce.org>

I'm working on patch parsing support for JGit, so I can rely on it in Gerrit 2. Currently Gerrit 1 uses a bastard chunk of code I ripped out in an hour to scan the output of "git diff"; its not suitable for long-term appliction.

This series improves RawParseUtils code clarity, and then adds support for the C-style quoting rules used by git diff when file names contain "special" characters like LF.

I'm working on patch parsing right now; but I wanted to send this preliminary series out so you aren't drowning in code to review.

Shawn O. Pearce (6):
  Simplify RawParseUtils.nextLF invocations
  Simplify RawParseUtils next and nextLF loops
  Correct Javadoc of RawParseUtils next and nextLF methods
  Add QuotedString class to handle C-style quoting rules
  Add Bourne style quoting for TransportGitSsh
  Add ~user friendly Bourne style quoting for TransportGitSsh
 .../jgit/util/QuotedStringBourneStyleTest.java     |  111 ++++++
 .../util/QuotedStringBourneUserPathStyleTest.java  |  130 +++++++
 .../spearce/jgit/util/QuotedStringC_StyleTest.java |  144 ++++++++
 .../src/org/spearce/jgit/lib/ObjectChecker.java    |    4 +-
 .../src/org/spearce/jgit/revwalk/RevTag.java       |    2 +-
 .../spearce/jgit/transport/TransportGitSsh.java    |   38 +--
 .../src/org/spearce/jgit/util/QuotedString.java    |  364 ++++++++++++++++++++
 .../src/org/spearce/jgit/util/RawParseUtils.java   |   45 ++-
 8 files changed, 783 insertions(+), 55 deletions(-)
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneStyleTest.java
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneUserPathStyleTest.java
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringC_StyleTest.java
 create mode 100644 org.spearce.jgit/src/org/spearce/jgit/util/QuotedString.java
Next: Shawn O. Pearce
Message 1 of 11 in “RawParseUtil improvements”
  1. 0/6 RawParseUtil improvementsShawn O. Pearce, Dec 10, 2008
  2. 1/6 Simplify RawParseUtils.nextLF invocationsShawn O. Pearce, Dec 10, 2008
  3. 2/6 Simplify RawParseUtils next and nextLF loopsShawn O. Pearce, Dec 10, 2008
  4. 3/6 Correct Javadoc of RawParseUtils next and nextLF methodsShawn O. Pearce, Dec 10, 2008
  5. 4/6 Add QuotedString class to handle C-style quoting rulesShawn O. Pearce, Dec 10, 2008
  6. 5/6 Add Bourne style quoting for TransportGitSshShawn O. Pearce, Dec 10, 2008
  7. 6/6 Add ~user friendly Bourne style quoting for TransportGitSshShawn O. Pearce, Dec 10, 2008
  8. Robin RosenbergDec 10, 2008
  9. Shawn O. PearceDec 10, 2008
  10. Robin RosenbergDec 11, 2008
  11. 4/6 Add QuotedString class to handle Git path style quoting rulesShawn O. Pearce, Dec 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.