git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email: provide hook to send lines more than 998 symbols

From
AArafangion <thestar@fussycoder.id.au>
Date
Nov 21, 2008, 11:09 UTC
Message-ID
<1227265742.3311.8.camel@therock.nsw.bigpond.net.au>
In-Reply-To
<5ec8ebd50811210237kd6f9341q23bc69b6ffcc2a87@mail.gmail.com>
On Fri, 2008-11-21 at 12:37 +0200, Andy Shevchenko wrote:
> On Fri, Nov 21, 2008 at 12:34 PM, Arafangion <thestar@fussycoder.id.au> wrote:
> >> By default git-send-email does not accept patch which is contain lines longer
> >> than 998 symbols. Sometime it's inconvenient, i.e. you have a long list in one
<snip>
> > As a curiosity, why is such a check even neccessary?
> I'm not an author of that strange check (possible it's somehow related
> to b8ebe08b9a643f432866eb7150c3b20d59b755f2)

I can't seem to find that changeset, however the reason why I asked is because I thought I remembered that some mail clients could crash if they got lines longer than that, and we should cater for that even if those clients should handle mails better than that! Apparently it's specified in the relevant RFC2822, and this particular solution has already been contributed as: https://kerneltrap.org/mailarchive/git/2008/1/18/579779

I would be inclined to suggest that such patches should be sent as an attachment instead? (Though this may become bikeshed painting on my part, see http://www.freebsd.org/doc/en/articles/mailing-list-faq/bikeshed.html for what I mean by the term).

While patches should be sent inline to encourage discussion of the patch, if the patch has such insanely long lines, the probability that the bulk of your audience in having a good email client that doesn't mangle your patch may become rather low.

(I really should get some sleep, not good to be argumentative when people are contributing very useful patches, like yourself!)

Previous: Andy ShevchenkoNext: Andreas Ericsson
Message 6 of 12 in “git-send-email: provide hook to send lines more than 998 symbols”
  1. git-send-email: provide hook to send lines more than 998 symbolsAndy Shevchenko, Nov 21, 2008
  2. ArafangionNov 21, 2008
  3. Andy ShevchenkoNov 21, 2008
  4. Teemu LikonenNov 21, 2008
  5. Andy ShevchenkoNov 21, 2008
  6. ArafangionNov 21, 2008
  7. Andreas EricssonNov 21, 2008
  8. Jeff KingNov 21, 2008
  9. Jeff KingNov 21, 2008
  10. Michael J GruberNov 21, 2008
  11. Andy ShevchenkoNov 21, 2008
  12. Jeff KingNov 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.