Re: [PATCH 2/2] Cached the git configuration, which is now noticibly faster on windows.
Thanks for making those patches more visible, however I do feel the need
to mention one thing I expected to have been raised during patch review:
1) The memory optimisation may cause significant slowdown, which wasn't
a big issue on my machine, perhaps because I'm _still_ trying to get it
to work on my particular repo. (It's still using too much memory), and I
have a very fast machine. It switches git-p4 from a RAM-intensive app
to a somewhat-less-RAM-intensive app at the cost of also becomming much
more CPU-intensive.
On Tue, 2008-11-11 at 16:50 -0800, Junio C Hamano wrote:
Show 24 quoted lines
> Simon Hausmann <simon@lst.de> writes:
>
> > On Sunday 09 November 2008 Junio C Hamano, wrote:
> >> These are patches to fast-import/git-p4, which you two seem to in charge
> >> of.
> >>
> >> From: John Chapman <thestar@fussycoder.id.au>
> >> Subject: [PATCH 1/2] Added support for purged files and also optimised
> >> memory usage. Date: Sat, 8 Nov 2008 14:22:48 +1100
> >> Message-Id: <1226114569-8506-1-git-send-email-thestar@fussycoder.id.au>
> >>
> >> From: John Chapman <thestar@fussycoder.id.au>
> >> Subject: [PATCH 2/2] Cached the git configuration, which is now
> >> noticibly faster on windows. Date: Sat, 8 Nov 2008 14:22:49 +1100
> >> Message-Id: <1226114569-8506-2-git-send-email-thestar@fussycoder.id.au>
> >>
> >> It was unfortunately not immediately obvious from the Subject: line what
> >> these patches are about, and I am guessing you missed them because of that.
> >
> > Ack on both patches. The second one could be done better, as suggested
> > in the follow-ups, but both are clearly an improvement :)
>
> Thanks, both of you. Will apply.
>