git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[EGIT PATCH 4/8] Align commit text properly in jgit glog

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Sep 30, 2008, 23:53 UTC
Message-ID
<1222818823-22780-4-git-send-email-robin.rosenberg@dewire.com>
In-Reply-To
<1222818823-22780-3-git-send-email-robin.rosenberg@dewire.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
 .../egit/ui/internal/history/SWTPlotRenderer.java  |    3 ---
 .../org/spearce/jgit/awtui/AWTPlotRenderer.java    |    7 +++----
 2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/SWTPlotRenderer.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/SWTPlotRenderer.java
index a58b3bf..7c286a4 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/SWTPlotRenderer.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/SWTPlotRenderer.java
@@ -51,9 +51,6 @@ protected void finalize() throws Throwable {
 		sys_blue.dispose();
 		sys_gray.dispose();
 		sys_darkblue.dispose();
-		sys_yellow.dispose();
-		sys_green.dispose();
-		sys_white.dispose();
 	}
 	
 	void paint(final Event event) {
diff --git a/org.spearce.jgit/src/org/spearce/jgit/awtui/AWTPlotRenderer.java b/org.spearce.jgit/src/org/spearce/jgit/awtui/AWTPlotRenderer.java
index a9933a4..5090ec9 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/awtui/AWTPlotRenderer.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/awtui/AWTPlotRenderer.java
@@ -10,7 +10,6 @@
 
 import org.spearce.jgit.awtui.CommitGraphPane.GraphCellRender;
 import org.spearce.jgit.awtui.SwingCommitList.SwingLane;
-import org.spearce.jgit.lib.Ref;
 import org.spearce.jgit.revplot.AbstractPlotRenderer;
 import org.spearce.jgit.revplot.PlotCommit;
 
@@ -76,10 +75,10 @@ protected void drawBoundaryDot(final int x, final int y, final int w,
 
 	@Override
 	protected void drawText(final String msg, final int x, final int y) {
-		final int texty = g.getFontMetrics().getHeight()
-				- g.getFontMetrics().getDescent();
+		final int texth = g.getFontMetrics().getHeight();
+		final int y0 = y - texth/2 + (cell.getHeight() - texth)/2;
 		g.setColor(cell.getForeground());
-		g.drawString(msg, x, texty - (cell.getHeight() - y * 2));
+		g.drawString(msg, x, y0 + texth - g.getFontMetrics().getDescent());
 	}
 
 	@Override
-- 
1.6.0.1.310.gf789d0.dirty
Previous: Robin RosenbergNext: Robin Rosenberg
Message 4 of 13 in “Set table row height for the glog JTable”
  1. 1/8 Set table row height for the glog JTableRobin Rosenberg, Sep 30, 2008
  2. 2/8 Move AWTPlotRenderer to its own file.Robin Rosenberg, Sep 30, 2008
  3. 3/8 Dispose of allocated colors on finalize()Robin Rosenberg, Sep 30, 2008
  4. 4/8 Align commit text properly in jgit glogRobin Rosenberg, Sep 30, 2008
  5. Robin RosenbergOct 1, 2008
  6. Shawn O. PearceOct 1, 2008
  7. 0/3 jgit glog alignment fixesRobin Rosenberg, Oct 1, 2008
  8. 1/3 Set table row height for the glog JTableRobin Rosenberg, Oct 1, 2008
  9. 2/3 Move AWTPlotRenderer to its own file.Robin Rosenberg, Oct 1, 2008
  10. 3/3 Align commit text properly in jgit glogRobin Rosenberg, Oct 1, 2008
  11. Shawn O. PearceOct 1, 2008
  12. Robin RosenbergOct 1, 2008
  13. Shawn O. PearceOct 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.