[PATCH] gitweb: Sort the list of forks on the summary page by age

From: Petr Baudis <pasky@suse.cz>
Date: Sep 25, 2008, 16:48 UTC
Message-ID: <1222361328-17368-1-git-send-email-pasky@suse.cz>
In-Reply-To: <1222361317-17275-1-git-send-email-pasky@suse.cz>

From: Petr Baudis <pasky@suse.cz>

From: Mike Ralphson <mike@abacus.co.uk>

The list of forks on the summary page was unsorted, this just makes them sorted by age, which seems a fair way to decide which forks are shown before the list size cut-off (15) kicks in.

s/noheader/no_header was just to make it obvious what the parameter affects, so all the code can be found with one grep.

pb: As suggested by Mike, I have augmented this by an additional patch that refactors the sorting logic so that it is not tied to printing the headers.

Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
Signed-off-by: Petr Baudis <pasky@suse.cz>

---
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bd81e14..0f8a564 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4119,10 +4119,10 @@ sub git_summary {
 
 	if (@forklist) {
 		git_print_header_div('forks');
-		git_project_list_body(\@forklist, undef, 0, 15,
+		git_project_list_body(\@forklist, 'age', 0, 15,
 		                      $#forklist <= 15 ? undef :
 		                      $cgi->a({-href => href(action=>"forks")}, "..."),
-		                      'noheader');
+		                      'no_header');
 	}
 
 	git_footer_html();

-- 
tg: (513dad1..) t/forks/sort-by-age (depends on: t/forks/sort-refactor)