[PATCH] Fix removing non-pushable remotes
- From
Petr Baudis <pasky@suse.cz>
- Date
- Sep 24, 2008, 23:32 UTC
- Message-ID
- <1222299167-4305-1-git-send-email-pasky@suse.cz>
- In-Reply-To
- <20080924204616.189163849@suse.cz>
Git-gui does not add most of the remotes to the 'push' menu since they are missing the "Push" line in their remotespec. In that case, removing the remote would end up with an error.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
Note that I think this should be abandoned and all remotes added to the push menu. Having the push part of the remotespec is actually a very rare situation and it is just not there in most of the cases, relying on default git push behaviour.
git-gui/lib/remote.tcl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/remote.tcl b/git-gui/lib/remote.tcl index 1852247..b92b429 100644 --- a/git-gui/lib/remote.tcl +++ b/git-gui/lib/remote.tcl @@ -271,5 +271,6 @@ proc remove_remote {name} { delete_from_menu $remote_m.fetch $name delete_from_menu $remote_m.prune $name delete_from_menu $remote_m.remove $name - delete_from_menu $remote_m.push $name + # Not all remotes are in the push menu + catch { delete_from_menu $remote_m.push $name } }
-- tg: (17f0c43..) t/git-gui/remove-push (depends on: git-gui/remotes)