git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: use_pathinfo filenames start with /

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Sep 3, 2008, 09:57 UTC
Message-ID
<1220435839-29360-3-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1220435839-29360-2-git-send-email-giuseppe.bilotta@gmail.com>

When using path info, make filenames start with a / (right after the : that separates them from the hash base). This minimal change allows relative navigation to work properly when viewing HTML files.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 496dce4..9d4952f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -664,7 +664,7 @@ sub href (%) {
 		if (defined $params{'hash_base'}) {
 			$href .= "/".esc_url($params{'hash_base'});
 			if (defined $params{'file_name'}) {
-				$href .= ":".esc_url($params{'file_name'});
+				$href .= ":/".esc_url($params{'file_name'});
 				delete $params{'hash'} if $params{'hash'} eq git_get_hash_by_path($params{'hash_base'},$params{'file_name'});
 				delete $params{'file_name'};
 			} else {
-- 
1.5.6.5
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 3 of 11 in “gitweb pathinfo improvements”
  1. Giuseppe BilottaSep 3, 2008
  2. gitweb: action in path with use_pathinfoGiuseppe Bilotta, Sep 3, 2008
  3. gitweb: use_pathinfo filenames start with /Giuseppe Bilotta, Sep 3, 2008
  4. gitweb: parse parent..current syntax from pathinfoGiuseppe Bilotta, Sep 3, 2008
  5. gitweb: use_pathinfo creates parent..current pathsGiuseppe Bilotta, Sep 3, 2008
  6. gitweb: remove PATH_INFO from $my_url and $my_uriGiuseppe Bilotta, Sep 3, 2008
  7. Giuseppe BilottaSep 3, 2008
  8. Junio C HamanoSep 4, 2008
  9. Jakub NarebskiSep 6, 2008
  10. Giuseppe BilottaSep 6, 2008
  11. Jakub NarebskiSep 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.