git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 05/14] Fix usage of assertEquals in DirCacheIteratorTest

From
Shawn O. Pearce <spearce@spearce.org>
Date
Aug 18, 2008, 23:53 UTC
Message-ID
<1219103602-32222-6-git-send-email-spearce@spearce.org>
In-Reply-To
<1219103602-32222-5-git-send-email-spearce@spearce.org>

I had the expected/actual values reversed so error messages from JUnit were a bit difficult to read.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../jgit/dircache/DirCacheIteratorTest.java        |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheIteratorTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheIteratorTest.java
index 7d4e6bb..62a162f 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheIteratorTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheIteratorTest.java
@@ -87,7 +87,7 @@ public void testNoSubtree_NoTreeWalk() throws Exception {
 			assertSame(ents[pathIdx], i.getDirCacheEntry());
 			pathIdx++;
 		}
-		assertEquals(pathIdx, paths.length);
+		assertEquals(paths.length, pathIdx);
 	}
 
 	public void testNoSubtree_WithTreeWalk() throws Exception {
@@ -120,7 +120,7 @@ public void testNoSubtree_WithTreeWalk() throws Exception {
 			assertSame(modes[pathIdx], tw.getFileMode(0));
 			pathIdx++;
 		}
-		assertEquals(pathIdx, paths.length);
+		assertEquals(paths.length, pathIdx);
 	}
 
 	public void testSingleSubtree_NoRecursion() throws Exception {
@@ -164,7 +164,7 @@ public void testSingleSubtree_NoRecursion() throws Exception {
 
 			pathIdx++;
 		}
-		assertEquals(pathIdx, expPaths.length);
+		assertEquals(expPaths.length, pathIdx);
 	}
 
 	public void testSingleSubtree_Recursive() throws Exception {
@@ -199,7 +199,7 @@ public void testSingleSubtree_Recursive() throws Exception {
 			assertSame(mode, tw.getFileMode(0));
 			pathIdx++;
 		}
-		assertEquals(pathIdx, paths.length);
+		assertEquals(paths.length, pathIdx);
 	}
 
 	public void testTwoLevelSubtree_Recursive() throws Exception {
@@ -233,7 +233,7 @@ public void testTwoLevelSubtree_Recursive() throws Exception {
 			assertSame(mode, tw.getFileMode(0));
 			pathIdx++;
 		}
-		assertEquals(pathIdx, paths.length);
+		assertEquals(paths.length, pathIdx);
 	}
 
 	public void testTwoLevelSubtree_FilterPath() throws Exception {
-- 
1.6.0.87.g2858d
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 6 of 20 in “TreeWalk D/F conflict detection”
  1. 00/14 TreeWalk D/F conflict detectionShawn O. Pearce, Aug 18, 2008
  2. 01/14 Detect path names which overflow the name length field in the indexShawn O. Pearce, Aug 18, 2008
  3. 02/14 Fix NB.decodeUInt16 to correctly handle the high byteShawn O. Pearce, Aug 18, 2008
  4. 03/14 Add test cases for NB.encode and NB.decode family of routinesShawn O. Pearce, Aug 18, 2008
  5. 04/14 Fix DirCache's skip over null byte padding when reading a DIRC fileShawn O. Pearce, Aug 18, 2008
  6. 05/14 Fix usage of assertEquals in DirCacheIteratorTestShawn O. Pearce, Aug 18, 2008
  7. 06/14 Refactor AbstractTreeIterator.pathCompare to force another modeShawn O. Pearce, Aug 18, 2008
  8. 07/14 Micro-optimize AbstractTreeIterator.pathCompareShawn O. Pearce, Aug 18, 2008
  9. 08/14 Optimize path comparsion within subtrees during TreeWalkShawn O. Pearce, Aug 18, 2008
  10. 09/14 Refactor AbstractTreeIterator semantics to start on first entryShawn O. Pearce, Aug 18, 2008
  11. 10/14 Make all AbstractTreeIterator implementations bi-directionalShawn O. Pearce, Aug 18, 2008
  12. 11/14 Expose beginning of iterator indication from AbstractTreeIteratorShawn O. Pearce, Aug 18, 2008
  13. 12/14 Allow application code to set ObjectIds in DirCacheEntryShawn O. Pearce, Aug 18, 2008
  14. 13/14 Create NameConflictTreeWalk to transparently detect D/F conflictsShawn O. Pearce, Aug 18, 2008
  15. 14/14 Add test case for NameConflictTreeWalkShawn O. Pearce, Aug 18, 2008
  16. Junio C HamanoAug 19, 2008
  17. Robin RosenbergAug 19, 2008
  18. Shawn O. PearceAug 19, 2008
  19. David WoodhouseAug 19, 2008
  20. Shawn O. PearceAug 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.