git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Utilise our new p4_read_pipe and p4_write_pipe wrappers

From
AKAnand Kumria <wildfire@progsoc.org>
Date
Aug 14, 2008, 22:40 UTC
Message-ID
<1218753639-32716-2-git-send-email-wildfire@progsoc.org>
In-Reply-To
<1218753639-32716-1-git-send-email-wildfire@progsoc.org>
Signed-off-by: Anand Kumria <wildfire@progsoc.org>
---
 contrib/fast-import/git-p4 |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 3e9df70..12fa9d3 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -141,7 +141,7 @@ def setP4ExecBit(file, mode):
 def getP4OpenedType(file):
     # Returns the perforce file type for the given file.
 
-    result = read_pipe("p4 opened %s" % file)
+    result = p4_read_pipe("opened %s" % file)
     match = re.match(".*\((.+)\)\r?$", result)
     if match:
         return match.group(1)
@@ -681,7 +681,7 @@ class P4Submit(Command):
             submitTemplate = self.prepareLogMessage(template, logMessage)
             if os.environ.has_key("P4DIFF"):
                 del(os.environ["P4DIFF"])
-            diff = read_pipe("p4 diff -du ...")
+            diff = p4_read_pipe("diff -du ...")
 
             newdiff = ""
             for newFile in filesToAdd:
@@ -719,7 +719,7 @@ class P4Submit(Command):
             if self.isWindows:
                 submitTemplate = submitTemplate.replace("\r\n", "\n")
 
-            write_pipe("p4 submit -i", submitTemplate)
+            p4_write_pipe("submit -i", submitTemplate)
         else:
             fileName = "submit.txt"
             file = open(fileName, "w+")
-- 
1.5.6.3
Previous: Anand Kumria
Message 2 of 2 in “Add p4 read_pipe and write_pipe wrappers”
  1. 1/2 Add p4 read_pipe and write_pipe wrappersAnand Kumria, Aug 14, 2008
  2. 2/2 Utilise our new p4_read_pipe and p4_write_pipe wrappersAnand Kumria, Aug 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.