git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/12] Switch to using 'p4_build_cmd'

From
AKAnand Kumria <wildfire@progsoc.org>
Date
Aug 10, 2008, 18:26 UTC
Message-ID
<1218392795-4084-8-git-send-email-wildfire@progsoc.org>
In-Reply-To
<1218392795-4084-7-git-send-email-wildfire@progsoc.org>
Signed-off-by: Anand Kumria <wildfire@progsoc.org>
---
 contrib/fast-import/git-p4 |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index d36b0c6..2b6ea74 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -72,9 +72,7 @@ def read_pipe_lines(c):
 
 def p4_read_pipe_lines(c):
     """Specifically invoke p4 on the command supplied. """
-    real_cmd = "%s %s" % ("p4", c)
-    if verbose:
-        print real_cmd
+    real_cmd = p4_build_cmd(c)
     return read_pipe_lines(real_cmd)
 
 def system(cmd):
@@ -85,9 +83,7 @@ def system(cmd):
 
 def p4_system(cmd):
     """Specifically invoke p4 as the system command. """
-    real_cmd = "%s %s" % ("p4", cmd)
-    if verbose:
-        print real_cmd
+    real_cmd = p4_build_cmd(cmd)
     return system(real_cmd)
 
 def isP4Exec(kind):
@@ -172,7 +168,7 @@ def isModeExecChanged(src_mode, dst_mode):
     return isModeExec(src_mode) != isModeExec(dst_mode)
 
 def p4CmdList(cmd, stdin=None, stdin_mode='w+b'):
-    cmd = "p4 -G %s" % cmd
+    cmd = p4_build_cmd("-G %s" % (cmd))
     if verbose:
         sys.stderr.write("Opening pipe: %s\n" % cmd)
 

-- 
1.5.6.3
Previous: Anand KumriaNext: Anand Kumria
Message 8 of 16 in “Allow users to access Perforce repositories requiring authentication”
  1. 00/12 Allow users to access Perforce repositories requiring authenticationAnand Kumria, Aug 10, 2008
  2. 01/12 Create a specific version of the read_pipe_lines command for p4 invocationsAnand Kumria, Aug 10, 2008
  3. 02/12 Utilise the new 'p4_read_pipe_lines' commandAnand Kumria, Aug 10, 2008
  4. 03/12 Have a command that specifically invokes 'p4' (via system)Anand Kumria, Aug 10, 2008
  5. 04/12 Utilise the new 'p4_system' function.Anand Kumria, Aug 10, 2008
  6. 05/12 Add a single command that will be used to construct the 'p4' commandAnand Kumria, Aug 10, 2008
  7. 06/12 If we are in verbose mode, output what we are about to run (or return)Anand Kumria, Aug 10, 2008
  8. 07/12 Switch to using 'p4_build_cmd'Anand Kumria, Aug 10, 2008
  9. 08/12 If the user has configured various parameters, use them.Anand Kumria, Aug 10, 2008
  10. 09/12 Consistently use 'git-p4' for the configuration entriesAnand Kumria, Aug 10, 2008
  11. 10/12 Move git-p4.syncFromOrigin into a configuration parameters sectionAnand Kumria, Aug 10, 2008
  12. 11/12 Put some documentation in about the parameters that have been addedAnand Kumria, Aug 10, 2008
  13. 12/12 Put in the two other configuration elements found in the sourceAnand Kumria, Aug 10, 2008
  14. Simon HausmannAug 13, 2008
  15. Tor Arvid LundAug 14, 2008
  16. Anand KumriaAug 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.