git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bash: remove redundant check for 'git stash apply' options

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Aug 6, 2008, 15:45 UTC
Message-ID
<1218037523-32266-1-git-send-email-szeder@ira.uka.de>
In-Reply-To
<1217915438-6838-6-git-send-email-lee.marlow@gmail.com>

It will never trigger anyway because of the first check, and even if it would, it would not offer the command line option.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 447cb06..5d60f82 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1427,7 +1427,7 @@ _git_stash ()
 		apply,--*)
 			__gitcomp "--index"
 			;;
-		show,--*|apply,--*|drop,--*|pop,--*|branch,--*)
+		show,--*|drop,--*|pop,--*|branch,--*)
 			COMPREPLY=()
 			;;
 		show,*|apply,*|drop,*|pop,*|branch,*)

-- 
1.6.0.rc1.104.gf5b36
Previous: Lee MarlowNext: Shawn O. Pearce
Message 9 of 13 in “bash completion: more porcelain completions”
  1. 0/8 bash completion: more porcelain completionsLee Marlow, Aug 5, 2008
  2. 1/8 bash completion: Add completion for 'git clone'Lee Marlow, Aug 5, 2008
  3. 2/8 bash completion: Add completion for 'git clean'Lee Marlow, Aug 5, 2008
  4. 3/8 bash completion: Add completion for 'git init'Lee Marlow, Aug 5, 2008
  5. 4/8 bash completion: Add completion for 'git revert'Lee Marlow, Aug 5, 2008
  6. 5/8 bash completion: More completions for 'git stash'Lee Marlow, Aug 5, 2008
  7. 6/8 bash completion: Add completion for 'git archive'Lee Marlow, Aug 5, 2008
  8. 7/8 bash completion: Add completion for 'git ls-files'Lee Marlow, Aug 5, 2008
  9. bash: remove redundant check for 'git stash apply' optionsSZEDER Gábor, Aug 6, 2008
  10. Shawn O. PearceAug 6, 2008
  11. Shawn O. PearceAug 5, 2008
  12. Junio C HamanoAug 5, 2008
  13. Shawn O. PearceAug 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.