git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Gitweb: Provide Git links in project list?

From
JJ.H. <warthog19@eaglescrag.net>
Date
Aug 4, 2008, 16:26 UTC
Message-ID
<1217867214.32240.61.camel@localhost.localdomain>
In-Reply-To
<20080804101200.GC811@erda.amd.com>
Robert,

Noticed, but while I agree cloneurl is good - I think it kind of defeats the purpose of what I was originally intending with the 'git' link. I've gone back in to understand cloneurl better and I genuinely think this is the wrong approach (or at least not what was originally intended with the 'git' link as I envisioned it).

The git link was always meant / intended to be a link to acquire the git repository directly, and be independent of what is actually present in the cloneurl file, specifically I wanted it to be a (1) git url (git://<hostname>/<path>) so that it took advantage of git specifically vs. accidentally giving you something with ssh or http. and (2) was uniform and did *not* depend on something in the repository as with large set of repositories, kernel.org, there is no way we can police this and we explicitly do not want to have a script that automatically adds this or what not.

I have two other concerns with the patch your proposing

(1) it's on by default, and it seems that there are a number of sites that don't actually want this functionality, making it a configurable option would seem prudent in that case

(2) ignoring my comments on why I think using cloneurl for a large site is bad (after I looked into it), blindly on taking the first option in the file may lead to the display of unexpected or unintended URLs.

That said, it's probably worth merging the two patches (since I'm already there with the configuration options, etc) that way people can get either functionality should they choose.

- John 'Warthog9' Hawley
On Mon, 2008-08-04 at 12:12 +0200, Robert Richter wrote:
Show 18 quoted lines
> On 03.08.08 13:53:13, J.H. wrote:
> > Working on refactoring the patch so that it can go upstream, one of the
> > things I'm definitely making an assumption about (in my original code)
> > is that the base url will be uniform for the entire project_list (as it
> > is on kernel.org).  If that's acceptable I will probably be able to
> > submit something today, if not I will need to muck about and read out
> > the url from .git/cloneurl (which would be a rather hefty performance
> > hit - needing to read that from each repository)
> 
> John,
> 
> I just sent out a patch that implements this using cloneurl. It seemed
> small and easy to implement and so I just made the change myself.
> 
> Thank you anyway.
> 
> -Robert
>
Previous: Robert RichterNext: Petr Baudis
Message 12 of 14 in “Gitweb: Provide Git links in project list?”
  1. Robert RichterJul 30, 2008
  2. Fredrik SkolmliJul 30, 2008
  3. Robert RichterJul 30, 2008
  4. Fredrik SkolmliJul 30, 2008
  5. Bert WesargJul 30, 2008
  6. Robert RichterJul 30, 2008
  7. J.H.Jul 30, 2008
  8. Robert RichterJul 30, 2008
  9. J.H.Aug 3, 2008
  10. Gitweb: Provide Git links in project listRobert Richter, Aug 4, 2008
  11. Robert RichterAug 4, 2008
  12. J.H.Aug 4, 2008
  13. Petr BaudisAug 4, 2008
  14. Boyd Lynn GerberJul 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.