Re: [PATCH 1/1] Add "git" link to the end of project line on the project_list page.

From: J.H. <warthog19@eaglescrag.net>
Date: Aug 4, 2008, 02:38 UTC
Message-ID: <1217817517.32240.46.camel@localhost.localdomain>
In-Reply-To: <20080804022656.GA32184@machine.or.cz>

On Mon, 2008-08-04 at 04:26 +0200, Petr Baudis wrote:

Show 26 quoted lines

> On Sun, Aug 03, 2008 at 07:00:17PM -0700, warthog19@eaglescrag.net wrote:
> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> > index 90cd99b..c33f4ed 100755
> > --- a/gitweb/gitweb.perl
> > +++ b/gitweb/gitweb.perl
> > @@ -108,6 +108,14 @@ our $mimetypes_file = undef;
> >  # could be even 'utf-8' for the old behavior)
> >  our $fallback_encoding = 'latin1';
> >  
> > +# enable / disable a final link on the project list page
> > +# that will be the location of that actuall git url
> > +# it will output this in the format:
> > +# git://hostname/path/to/tree.git
> > +# disabled = blank or undef
> > +# enable = url to prefix before filling in the trailing path to the git repo
> > +our $projectlist_gitlinkurl = undef;
> > +
> >  # rename detection options for git-diff and git-diff-tree
> >  # - default is '-M', with the cost proportional to
> >  #   (number of removed files) * (number of new files).
> 
> Note that I will soon submit a generic patch that lets you extend
> the link lists with custom entries - you could easily use that for
> the git links (I'm personally not convinced how useful they really are
> on the project list page), I will use them for the graphiclog, edit and
> fork links at repo.or.cz.

I've found them useful, and there were requests out on the mailing list for this to be added, thus the patching. It's not on by default, so it's impact should be minimal unless people specifically want the link.

> 
> > +                        print " | ". $cgi->a({-href => "git://projectlist_gitlinkurl/".esc_html($pr->{'path'})}, "git");
> 
> You meant $projectlist_gitlinkurl.

grrr - I've fixed that same bug twice now, had problems with something and must have reverted the wrong thing, I'll fix it and re-submit.

When you do the more generic patch to extend the links I'll flip this over to that code, unless you think it's worth holding off and waiting for that change to go in first?

- John 'Warthog9' Hawley