[PATCH] Use line buffering for standard output
- From
- Anders Melchiorsen <mail@cup.kalibalik.dk>
- Date
- Aug 3, 2008, 21:26 UTC
- Message-ID
- <1217798768-18021-1-git-send-email-mail@cup.kalibalik.dk>
Normally, stdout is fully buffered, unless it refers to a terminal device. This gives problems when fork() is in play: the buffer is cloned and output appears twice.
By always setting stdout to line buffering, we make the output work identically for all output devices.
Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> ---
On #git, blix mentioned that running git clone through a pipe made it output the "Initialized empty" line twice. This seems to be due to bad interactions between fork() and buffered stdio.
Rather than putting in flushing at all the right places, this sledgehammer fix simply reverts to line buffering for all output devices.
Anders.
git.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/git.c b/git.c index 37b1d76..040b900 100644 --- a/git.c +++ b/git.c @@ -421,6 +421,12 @@ int main(int argc, const char **argv) int done_alias = 0; /* + * Use line buffering, even if we do not have interactive + * output. Full buffering mixes badly with fork(). + */ + setvbuf(stdout, NULL, _IOLBF, 0); + + /* * Take the basename of argv[0] as the command * name, and the dirname as the default exec_path * if we don't have anything better.
-- 1.5.6.4