git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] builtin-branch: remove duplicated code

From
LHLars Hjemli <hjemli@gmail.com>
Date
Jul 26, 2008, 10:27 UTC
Message-ID
<1217068045-3575-2-git-send-email-hjemli@gmail.com>
In-Reply-To
<1217068045-3575-1-git-send-email-hjemli@gmail.com>

The previous optimization to --[no-]merged ended up with some duplicated code which this patch removes.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---
 builtin-branch.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index 5db8ad8..675a9b1 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -214,7 +214,6 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
 	struct commit *commit;
 	int kind;
 	int len;
-	static struct commit_list branch;
 
 	/* Detect kind */
 	if (!prefixcmp(refname, "refs/heads/")) {
@@ -238,13 +237,9 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
 	if ((kind & ref_list->kinds) == 0)
 		return 0;
 
-	if (merge_filter != NO_FILTER) {
-		branch.item = lookup_commit_reference_gently(sha1, 1);
-		if (!branch.item)
-			die("Unable to lookup tip of branch %s", refname);
+	if (merge_filter != NO_FILTER)
 		add_pending_object(&ref_list->revs,
-				   (struct object *)branch.item, refname);
-	}
+				   (struct object *)commit, refname);
 
 	/* Resize buffer */
 	if (ref_list->index >= ref_list->alloc) {
-- 
1.6.0.rc0.79.gb0320
Previous: Lars HjemliNext: Lars Hjemli
Message 2 of 4 in “builtin-branch --[no-]merged post-optimization fixes”
  1. 0/3 builtin-branch --[no-]merged post-optimization fixesLars Hjemli, Jul 26, 2008
  2. 1/3 builtin-branch: remove duplicated codeLars Hjemli, Jul 26, 2008
  3. 2/3 builtin-branch: factor out merge_filter matchingLars Hjemli, Jul 26, 2008
  4. 3/3 builtin-branch: fix -v for --[no-]mergedLars Hjemli, Jul 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.