git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[EGIT PATCH 3/3] Log decoration problems more silently

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Jul 10, 2008, 22:41 UTC
Message-ID
<1215729668-26865-4-git-send-email-robin.rosenberg@dewire.com>
In-Reply-To
<1215729668-26865-3-git-send-email-robin.rosenberg@dewire.com>
Seems our logging caused too much alerts in the UI.
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
 .../internal/decorators/GitResourceDecorator.java  |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
index 8d4a7c7..6d2f88e 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
@@ -146,7 +146,9 @@ public class GitResourceDecorator extends LabelProvider implements
 				}
 				return Status.OK_STATUS;
 			} catch (Exception e) {
-				return new Status(IStatus.ERROR, Activator.getPluginId(), "Failed to trigger resource decoration", e);
+				// We must be silent here or the UI will panic with lots of error messages
+				Activator.logError("Failed to trigger resource re-decoration", e);
+				return Status.OK_STATUS;
 			}
 		}
 
-- 
1.5.6.2.220.g44701
Previous: Robin Rosenberg
Message 4 of 4 in “Resource decorator improvements”
  1. 0/3 Resource decorator improvementsRobin Rosenberg, Jul 10, 2008
  2. 1/3 Use a job for the resource decoratorRobin Rosenberg, Jul 10, 2008
  3. 2/3 Avoid errors by allowing phantoms during traversal in the resource decoratorRobin Rosenberg, Jul 10, 2008
  4. 3/3 Log decoration problems more silentlyRobin Rosenberg, Jul 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.