[JGIT PATCH 2/5] Don't display passwords on the console in fetch/push output
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jul 10, 2008, 06:13 UTC
- Message-ID
- <1215670403-19191-3-git-send-email-spearce@spearce.org>
- In-Reply-To
- <1215670403-19191-2-git-send-email-spearce@spearce.org>
When we show the URI we just fetched or pushed against there may be a user password embedded in that URI, as saved in the user's .git/config file. We shouldn't display that in public to prying eyes so nulling it out will give us a copy of the URI without that field in it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- .../src/org/spearce/jgit/pgm/Fetch.java | 2 +- .../src/org/spearce/jgit/pgm/Push.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/pgm/Fetch.java b/org.spearce.jgit/src/org/spearce/jgit/pgm/Fetch.java index c9c997e..36a0592 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/pgm/Fetch.java +++ b/org.spearce.jgit/src/org/spearce/jgit/pgm/Fetch.java @@ -71,7 +71,7 @@ class Fetch extends TextBuiltin { return; out.print("From "); - out.print(tn.getURI()); + out.print(tn.getURI().setPass(null)); out.println(); for (final TrackingRefUpdate u : r.getTrackingRefUpdates()) { final char type = shortTypeOf(u.getResult()); diff --git a/org.spearce.jgit/src/org/spearce/jgit/pgm/Push.java b/org.spearce.jgit/src/org/spearce/jgit/pgm/Push.java index cbdf465..8411a11 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/pgm/Push.java +++ b/org.spearce.jgit/src/org/spearce/jgit/pgm/Push.java @@ -149,7 +149,7 @@ class Push extends TextBuiltin { final RemoteRefUpdate rru) { if (first) { first = false; - out.format("To %s\n", transport.getURI()); + out.format("To %s\n", transport.getURI().setPass(null)); } final String remoteName = rru.getRemoteName();
-- 1.5.6.2.393.g45096