git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove unused code in parse_commit_buffer()

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Jun 7, 2008, 20:38 UTC
Message-ID
<1212871117-1509-1-git-send-email-vmiklos@frugalware.org>

The n_refs variable is no longer really used in this function, so there is no reason to keep it.

It was introduced in 27dedf0c and the code that really used it was removed in 7914053.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 commit.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/commit.c b/commit.c
index 94d5b3d..e2d8624 100644
--- a/commit.c
+++ b/commit.c
@@ -243,7 +243,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)
 	unsigned char parent[20];
 	struct commit_list **pptr;
 	struct commit_graft *graft;
-	unsigned n_refs = 0;
 
 	if (item->object.parsed)
 		return 0;
@@ -255,8 +254,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)
 		return error("bad tree pointer in commit %s",
 			     sha1_to_hex(item->object.sha1));
 	item->tree = lookup_tree(parent);
-	if (item->tree)
-		n_refs++;
 	bufptr += 46; /* "tree " + "hex sha1" + "\n" */
 	pptr = &item->parents;
 
@@ -272,10 +269,8 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)
 		if (graft)
 			continue;
 		new_parent = lookup_commit(parent);
-		if (new_parent) {
+		if (new_parent)
 			pptr = &commit_list_insert(new_parent, pptr)->next;
-			n_refs++;
-		}
 	}
 	if (graft) {
 		int i;
@@ -285,7 +280,6 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)
 			if (!new_parent)
 				continue;
 			pptr = &commit_list_insert(new_parent, pptr)->next;
-			n_refs++;
 		}
 	}
 	item->date = parse_commit_date(bufptr, tail);
-- 
1.5.6.rc0.dirty
Next: Johannes Schindelin
Message 1 of 2 in “Remove unused code in parse_commit_buffer()”
  1. Remove unused code in parse_commit_buffer()Miklos Vajna, Jun 7, 2008
  2. Johannes SchindelinJun 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.