git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Avoid git-rev-parse warnings in gitweb blame

From
RGRafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date
Jun 3, 2008, 10:14 UTC
Message-ID
<1212488060-23251-1-git-send-email-rgarciasuarez@gmail.com>

Adding a '--' to the command-line avoids git-rev-parse emitting an error message "ambiguous argument... Use '--' to separate paths from revisions".

Signed-off-by: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 55fb100..472326f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4226,7 +4226,7 @@ HTML
 			              esc_html($rev));
 			print "</td>\n";
 		}
-		open (my $dd, "-|", git_cmd(), "rev-parse", "$full_rev^")
+		open (my $dd, "-|", git_cmd(), "rev-parse", '--', "$full_rev^")
 			or die_error(undef, "Open git-rev-parse failed");
 		my $parent_commit = <$dd>;
 		close $dd;
-- 
1.5.6.rc1
Next: Rafael Garcia-Suarez
Message 1 of 3 in “Avoid git-rev-parse warnings in gitweb blame”
  1. Avoid git-rev-parse warnings in gitweb blameRafael Garcia-Suarez, Jun 3, 2008
  2. Make cell alignment more robust in gitweb blameRafael Garcia-Suarez, Jun 3, 2008
  3. Rafael Garcia-SuarezJun 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.