[PATCH 2/2] graph API: avoid printing unnecessary padding before some octopus merges
- From
Adam Simpkins <adam@adamsimpkins.net>
- Date
- Jun 1, 2008, 20:56 UTC
- Message-ID
- <1212353818-7031-3-git-send-email-adam@adamsimpkins.net>
- In-Reply-To
- <1212353818-7031-2-git-send-email-adam@adamsimpkins.net>
When an octopus merge is printed, several lines are printed before it to move over existing branch lines to its right. This is needed to make room for the children of the octopus merge. For example:
| | | | | | \ \ | | \ \ | | \ \ | M---. \ \ | |\ \ \ \ \
However, this step isn't necessary if there are no branch lines to the right of the octopus merge. Therefore, skip this step when it is not needed, to avoid printing extra lines that don't really serve any purpose.
Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- graph.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/graph.c b/graph.c index 332d1e8..0531716 100644 --- a/graph.c +++ b/graph.c @@ -450,16 +450,18 @@ void graph_update(struct git_graph *graph, struct commit *commit) * it never finished its output. Goto GRAPH_SKIP, to print out * a line to indicate that portion of the graph is missing. * - * Otherwise, if there are 3 or more parents, we need to print - * extra rows before the commit, to expand the branch lines around - * it and make room for it. + * If there are 3 or more parents, we may need to print extra rows + * before the commit, to expand the branch lines around it and make + * room for it. We need to do this unless there aren't any branch + * rows to the right of this commit. * * If there are less than 3 parents, we can immediately print the * commit line. */ if (graph->state != GRAPH_PADDING) graph->state = GRAPH_SKIP; - else if (graph->num_parents >= 3) + else if (graph->num_parents >= 3 && + graph->commit_index < (graph->num_columns - 1)) graph->state = GRAPH_PRE_COMMIT; else graph->state = GRAPH_COMMIT; @@ -538,7 +540,8 @@ static void graph_output_skip_line(struct git_graph *graph, struct strbuf *sb) strbuf_addstr(sb, "..."); graph_pad_horizontally(graph, sb); - if (graph->num_parents >= 3) + if (graph->num_parents >= 3 && + graph->commit_index < (graph->num_columns - 1)) graph_update_state(graph, GRAPH_PRE_COMMIT); else graph_update_state(graph, GRAPH_COMMIT);
-- 1.5.6.rc0.54.g04bfd