git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: reducing prune sync()s

From
DDDavid Dillow <dave@thedillows.org>
Date
May 30, 2008, 01:51 UTC
Message-ID
<1212112295.3094.3.camel@obelisk.thedillows.org>
In-Reply-To
<alpine.LFD.1.10.0805291656260.3141@woody.linux-foundation.org>
On Thu, 2008-05-29 at 17:27 -0700, Linus Torvalds wrote:
Show 6 quoted lines
> That would be much better. The code was ported from shell script, and 
> there is no fsync() in shell, but the rule should basically be that you 
> can remove all the objects that correspond to a pack-file after you have 
> made sure that the pack-file (and it's index - we can re-generate the pack 
> index, but realistically speaking it's *much* better to not have to) is 
> stable on disk.

Even if the data is stable on disk, don't we also need to ensure the pack's connectivity to the namespace is also stable? Without an fsync() of the directory that contains it, could it go away?

Of course, this is me recollecting a several-year-old exchange on LKML, so I don't know if it is still needed or not, or on systems other than Linux.

Dave
Previous: Florian WeimerNext: Linus Torvalds
Message 6 of 15 in “reducing prune sync()s”
  1. Frank Ch. EiglerMay 29, 2008
  2. Linus TorvaldsMay 30, 2008
  3. Linus TorvaldsMay 30, 2008
  4. Frank Ch. EiglerMay 30, 2008
  5. Florian WeimerMay 30, 2008
  6. David DillowMay 30, 2008
  7. Linus TorvaldsMay 30, 2008
  8. Linus TorvaldsMay 30, 2008
  9. Frank Ch. EiglerMay 30, 2008
  10. Linus TorvaldsMay 30, 2008
  11. 1/2 Make pack creation always fsync() the resultLinus Torvalds, May 30, 2008
  12. 2/2 Remove now unnecessary 'sync()' callsLinus Torvalds, May 30, 2008
  13. Nicolas PitreMay 30, 2008
  14. Frank Ch. EiglerMay 31, 2008
  15. Linus TorvaldsJun 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.