[PATCH 2/5] checkout: make reset_clean_to_new() not die by itself
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 29, 2008, 00:17 UTC
- Message-ID
- <1212020246-26480-3-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1212020246-26480-2-git-send-email-gitster@pobox.com>
Instead, have its error percolate up through the callchain and let it be the exit status of the main command. No semantic changes yet.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin-checkout.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/builtin-checkout.c b/builtin-checkout.c index 00dc8ca..cc97724 100644 --- a/builtin-checkout.c +++ b/builtin-checkout.c @@ -172,7 +172,7 @@ static int reset_to_new(struct tree *tree, int quiet) return 0; } -static void reset_clean_to_new(struct tree *tree, int quiet) +static int reset_clean_to_new(struct tree *tree, int quiet) { struct unpack_trees_options opts; struct tree_desc tree_desc; @@ -189,7 +189,8 @@ static void reset_clean_to_new(struct tree *tree, int quiet) parse_tree(tree); init_tree_desc(&tree_desc, tree->buffer, tree->size); if (unpack_trees(1, &tree_desc, &opts)) - exit(128); + return 128; + return 0; } struct checkout_opts { @@ -295,7 +296,9 @@ static int merge_working_tree(struct checkout_opts *opts, return ret; merge_trees(new->commit->tree, work, old->commit->tree, new->name, "local", &result); - reset_clean_to_new(new->commit->tree, opts->quiet); + ret = reset_clean_to_new(new->commit->tree, opts->quiet); + if (ret) + return ret; } }
-- 1.5.6.rc0.43.g823ea