Re: sharedRepository derived from file permissions

From: Mark Hills <mark@pogo.org.uk>
Date: Oct 16, 2012, 23:20 UTC
Message-ID: <1210170009180.2113@vega>
In-Reply-To: <7vhaq4nc7g.fsf@alter.siamese.dyndns.org>

On Mon, 8 Oct 2012, Junio C Hamano wrote:

Show 20 quoted lines

> Mark Hills <mark@pogo.org.uk> writes:
> 
> > We make extensive use of unix permissions and core.sharedRepository -- 
> > multiple developers push to the same repo.
> >
> > I have often wondered why core.sharedRepository is needed at all as a 
> > separate configuration?
> >
> > It looks like it might be easier (and less confusing to users) to derive 
> > this attribute from the top-level .git directory?
> 
> Hrm, clever ;-)
> 
> > Is there a reason why Git doesn't just follow (and echo) the top-level 
> > permissions?
> 
> Other than "we did not trust that all the end users are capable of
> doing the right 'chmod 2775 .git && chgrp project .git", with a
> little bit of "we didn't think of that when we wrote the system", I
> do not recall any.

Thanks. If I understand, you mean it might be worth a try to implement this. For us it would certainly simplify, and reduce mistakes/confusion.

I've yet to look into the code, but I will try and do this. If you have any hints or recommendations where to begin then that'd be good.

I think I did peek some years ago to find out that it was non-trivial, and then came up with the script!

I wonder if there are any users who are granting permission to specific branchs or tags or tag directories. I'm not sure if this is really a valid use case, but there might need to be a way to ignore the top-level attributes too for some special cases?

Thanks

-- 
Mark