git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Make git-svn tests behave better on OS X

From
Kevin Ballard <kevin@sb.org>
Date
Mar 21, 2008, 07:27 UTC
Message-ID
<1206084455-2793-1-git-send-email-kevin@sb.org>
In-Reply-To
<7vod98r210.fsf@gitster.siamese.dyndns.org>
This patch works fine for me.
-->8--

Give lib-git-svn.sh a few alternate paths to look for apache2. Explicitly define the LockFile so httpd will actually start under OS X

Signed-off-by: Kevin Ballard <kevin@sb.org>
---
 t/lib-git-svn.sh |   25 +++++++++++++++++++++++--
 1 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh
index 9ee35e7..9decd2e 100644
--- a/t/lib-git-svn.sh
+++ b/t/lib-git-svn.sh
@@ -49,8 +49,28 @@ poke() {
 	test-chmtime +1 "$1"
 }
 
-SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/lib/apache2/modules'}
-SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/apache2'}
+for d in \
+	"$SVN_HTTPD_PATH" \
+	/usr/sbin/apache2 \
+	/usr/sbin/httpd \
+; do
+	if test -f "$d"
+	then
+		SVN_HTTPD_PATH="$d"
+		break
+	fi
+done
+for d in \
+	"$SVN_HTTPD_MODULE_PATH" \
+	/usr/lib/apache2/modules \
+	/usr/libexec/apache2 \
+; do
+	if test -d "$d"
+	then
+		SVN_HTTPD_MODULE_PATH="$d"
+		break
+	fi
+done
 
 start_httpd () {
 	if test -z "$SVN_HTTPD_PORT"
@@ -66,6 +86,7 @@ ServerName "git-svn test"
 ServerRoot "$GIT_DIR"
 DocumentRoot "$GIT_DIR"
 PidFile "$GIT_DIR/httpd.pid"
+LockFile logs/accept.lock
 Listen 127.0.0.1:$SVN_HTTPD_PORT
 LoadModule dav_module $SVN_HTTPD_MODULE_PATH/mod_dav.so
 LoadModule dav_svn_module $SVN_HTTPD_MODULE_PATH/mod_dav_svn.so
-- 
1.5.5.rc0.23.gf91eb
Previous: Junio C HamanoNext: Eric Wong
Message 7 of 8 in “Make git-svn tests behave better on OS X”
  1. 1/2 Make git-svn tests behave better on OS XKevin Ballard, Mar 20, 2008
  2. 2/2 Don't try and percent-escape existing percent escapes in git-svn URIsKevin Ballard, Mar 20, 2008
  3. Eric WongMar 21, 2008
  4. Junio C HamanoMar 21, 2008
  5. Eric WongMar 21, 2008
  6. Junio C HamanoMar 21, 2008
  7. Make git-svn tests behave better on OS XKevin Ballard, Mar 21, 2008
  8. Eric WongMar 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.