git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] gitweb: Improved treatment of links with unknown object type

From
Jakub Narebski <jnareb@gmail.com>
Date
Mar 7, 2008, 21:03 UTC
Message-ID
<1204923800-5923-1-git-send-email-jnareb@gmail.com>

This series of patches make gitweb URLs without a= parameter to use 'object' view, which finds type of requested onject and redirects (HTTP redirect) to proper view, instead of just displaying this view. git_object() in turn is simplified to use git_get_type() subroutine, as was used for URLs without a=. As 'object' view is just internal implementation use no a= parameter instead of a=object for gitweb URLs for which type of object (and therefore view to be used) is not known.

I guess that this series of patches can be squashed into single commit, but I think that having them split into parts makes reviewing them easier; it also makes possible to drop indivisual commits, for example dropping second commit would leave gitweb with modified finding type of an object.

Shortlog:
=========
Jakub Narebski (3):
  gitweb: Redirect to appropriate view if 'a=' parameter is missing
  gitweb: Simplify object type detection in git_object()
  gitweb: Make 'object' action implicit by using no action URL
Diffstat:
=========
 gitweb/gitweb.perl |   45 +++++++++++----------------------------------
 1 files changed, 11 insertions(+), 34 deletions(-)

This series removes more than adds mainly thanks to second patch in the series which simplifies git_object() type detection code.

-- 
Jakub Narebski
ShadeHawk on #git
Poland
Next: Jakub Narebski
Message 1 of 4 in “gitweb: Improved treatment of links with unknown object type”
  1. 0/3 gitweb: Improved treatment of links with unknown object typeJakub Narebski, Mar 7, 2008
  2. 1/3 gitweb: Redirect to appropriate view if 'a=' parameter is missingJakub Narebski, Mar 7, 2008
  3. 2/3 gitweb: Simplify object type detection in git_object()Jakub Narebski, Mar 7, 2008
  4. 3/3 gitweb: Make 'object' action implicit by using no action URLJakub Narebski, Mar 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.