git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] add storage size output to 'git verify-pack -v'

From
Nicolas Pitre <nico@cam.org>
Date
Feb 28, 2008, 05:25 UTC
Message-ID
<1204176320-31358-5-git-send-email-nico@cam.org>
In-Reply-To
<1204176320-31358-4-git-send-email-nico@cam.org>

This can possibly break external scripts that depend on the previous output, but those script can't possibly be critical to Git usage, and fixing them should be trivial.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---
 Documentation/git-verify-pack.txt |    4 ++--
 contrib/stats/packinfo.pl         |    2 +-
 pack-check.c                      |    8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/git-verify-pack.txt b/Documentation/git-verify-pack.txt
index db019a2..ba2a157 100644
--- a/Documentation/git-verify-pack.txt
+++ b/Documentation/git-verify-pack.txt
@@ -32,11 +32,11 @@ OUTPUT FORMAT
 -------------
 When specifying the -v option the format used is:
 
-	SHA1 type size offset-in-packfile
+	SHA1 type size size-in-pack-file offset-in-packfile
 
 for objects that are not deltified in the pack, and
 
-	SHA1 type size offset-in-packfile depth base-SHA1
+	SHA1 type size size-in-packfile offset-in-packfile depth base-SHA1
 
 for objects that are deltified.
 
diff --git a/contrib/stats/packinfo.pl b/contrib/stats/packinfo.pl
index aab501e..f4a7b62 100755
--- a/contrib/stats/packinfo.pl
+++ b/contrib/stats/packinfo.pl
@@ -93,7 +93,7 @@ my %depths;
 my @depths;
 
 while (<STDIN>) {
-    my ($sha1, $type, $size, $offset, $depth, $parent) = split(/\s+/, $_);
+    my ($sha1, $type, $size, $space, $offset, $depth, $parent) = split(/\s+/, $_);
     next unless ($sha1 =~ /^[0-9a-f]{40}$/);
     $depths{$sha1} = $depth || 0;
     push(@depths, $depth || 0);
diff --git a/pack-check.c b/pack-check.c
index ae25685..0f8ad2c 100644
--- a/pack-check.c
+++ b/pack-check.c
@@ -128,11 +128,11 @@ static void show_pack_info(struct packed_git *p)
 						 base_sha1);
 		printf("%s ", sha1_to_hex(sha1));
 		if (!delta_chain_length)
-			printf("%-6s %lu %"PRIuMAX"\n",
-			       type, size, (uintmax_t)offset);
+			printf("%-6s %lu %lu %"PRIuMAX"\n",
+			       type, size, store_size, (uintmax_t)offset);
 		else {
-			printf("%-6s %lu %"PRIuMAX" %u %s\n",
-			       type, size, (uintmax_t)offset,
+			printf("%-6s %lu %lu %"PRIuMAX" %u %s\n",
+			       type, size, store_size, (uintmax_t)offset,
 			       delta_chain_length, sha1_to_hex(base_sha1));
 			if (delta_chain_length <= MAX_CHAIN)
 				chain_histogram[delta_chain_length]++;
-- 
1.5.4.2.200.g99e75
Previous: Nicolas PitreNext: Junio C Hamano
Message 5 of 8 in “enhancements to 'git verify-pack'”
  1. 0/4 enhancements to 'git verify-pack'Nicolas Pitre, Feb 28, 2008
  2. 1/4 factorize revindex code out of builtin-pack-objects.cNicolas Pitre, Feb 28, 2008
  3. 2/4 make verify_one_pack() a bit less wrong wrt packed_git structureNicolas Pitre, Feb 28, 2008
  4. 3/4 fix unimplemented packed_object_info_detail() featuresNicolas Pitre, Feb 28, 2008
  5. 4/4 add storage size output to 'git verify-pack -v'Nicolas Pitre, Feb 28, 2008
  6. Junio C HamanoMar 1, 2008
  7. Nicolas PitreMar 1, 2008
  8. Junio C HamanoMar 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.