git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH-v2 2/4] git-commit: set GIT_EDITOR=: if editor will not be launched

From
Paolo Bonzini <bonzini@gnu.org>
Date
Feb 5, 2008, 10:01 UTC
Message-ID
<1202205704-10024-2-git-send-email-bonzini@gnu.org>
In-Reply-To
<1202205704-10024-1-git-send-email-bonzini@gnu.org>
This is a preparatory patch that provides a simple way for the future
prepare-commit-msg hook to discover if the editor will be launched.
---
 Documentation/hooks.txt |    4 ++++
 builtin-commit.c        |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)
	This has not changed.
diff --git a/Documentation/hooks.txt b/Documentation/hooks.txt
index f110162..e8d80cf 100644
--- a/Documentation/hooks.txt
+++ b/Documentation/hooks.txt
@@ -61,6 +61,10 @@ The default 'pre-commit' hook, when enabled, catches introduction
 of lines with trailing whitespaces and aborts the commit when
 such a line is found.
 
+All the `git-commit` hooks are invoked with the environment
+variable `GIT_EDITOR=:` if the command will not bring up an editor
+to modify the commit message.
+
 commit-msg
 ----------
 
diff --git a/builtin-commit.c b/builtin-commit.c
index 405c8b5..7d1059c 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -599,6 +599,8 @@ static int parse_and_validate_options(int argc, const char *argv[],
 		use_editor = 0;
 	if (edit_flag)
 		use_editor = 1;
+	if (!use_editor)
+		setenv("GIT_EDITOR", ":", 1);
 
 	if (get_sha1("HEAD", head_sha1))
 		initial_commit = 1;
-- 
1.5.3.4.910.gc5122-dirty
Previous: Paolo BonziniNext: Paolo Bonzini
Message 2 of 9 in “git-commit: support variable number of hook arguments”
  1. 1/4 git-commit: support variable number of hook argumentsPaolo Bonzini, Feb 5, 2008
  2. 2/4 git-commit: set GIT_EDITOR=: if editor will not be launchedPaolo Bonzini, Feb 5, 2008
  3. 3/4 git-commit: Refactor creation of log message.Paolo Bonzini, Feb 5, 2008
  4. 4/4 git-commit: add a prepare-commit-msg hookPaolo Bonzini, Feb 5, 2008
  5. Johannes SchindelinFeb 5, 2008
  6. Paolo BonziniFeb 5, 2008
  7. Johannes SchindelinFeb 5, 2008
  8. Paolo BonziniFeb 5, 2008
  9. Junio C HamanoFeb 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.