[PATCH] autoconf: Add checking for unsetenv function
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jan 18, 2008, 01:03 UTC
- Message-ID
- <1200618231-28675-1-git-send-email-jnareb@gmail.com>
- In-Reply-To
- <20080117141143.38a88c7a@pc09.procura.nl>
Update configure.ac (and config.mak.in) by adding test for unsetenv (NO_UNSETENV). Add comment about NO_UNSETENV to Makefile header, as original commit 731043fd adding compat/unsetenv.c didn't do that.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> ---
Show 5 quoted lines
> * Failure of the configure/make to handle the lack of unsetenv() in > pre-11.31 HP-UX releases. Bizarrely, it does handle the lack of setenv() > and also has a compat/unsetenv.c for use by non-unsetenv()-capable OS'es, > but then configure and config.mak.in completely fail to use a NO_UNSETENV > variable like they should!
I'm sorry for that. When I was checking which tests were missing from configure.ac I have examined only Makefile header... and there was no note about NO_UNSETENV there.
But the above comment I think also means that the uname base "guessage" system in Makefile didn't catch that. You probably would want to modify Makefile in that direction too; currently "guessage system" sets NO_UNSETENV for and SunOS 5.8, SunOS 5.9, and you probably would want to use it also for (older?) HP-UX.
Makefile | 2 ++ config.mak.in | 1 + configure.ac | 6 ++++++ 3 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile index 82e9cd6..f35e269 100644 --- a/Makefile +++ b/Makefile @@ -38,6 +38,8 @@ all:: # # Define NO_SETENV if you don't have setenv in the C library. # +# Define NO_UNSETENV if you don't have unsetenv in the C library. +# # Define NO_MKDTEMP if you don't have mkdtemp in the C library. # # Define NO_SYMLINK_HEAD if you never want .git/HEAD to be a symbolic link. diff --git a/config.mak.in b/config.mak.in index 15fb26c..40b14d9 100644 --- a/config.mak.in +++ b/config.mak.in @@ -40,6 +40,7 @@ NO_MEMMEM=@NO_MEMMEM@ NO_STRLCPY=@NO_STRLCPY@ NO_STRTOUMAX=@NO_STRTOUMAX@ NO_SETENV=@NO_SETENV@ +NO_UNSETENV=@NO_UNSETENV@ NO_MKDTEMP=@NO_MKDTEMP@ NO_ICONV=@NO_ICONV@ OLD_ICONV=@OLD_ICONV@ diff --git a/configure.ac b/configure.ac index 6f641e3..af177fd 100644 --- a/configure.ac +++ b/configure.ac @@ -356,6 +356,12 @@ AC_CHECK_FUNC(setenv, [NO_SETENV=YesPlease]) AC_SUBST(NO_SETENV) # +# Define NO_UNSETENV if you don't have unsetenv in the C library. +AC_CHECK_FUNC(unsetenv, +[NO_UNSETENV=], +[NO_UNSETENV=YesPlease]) +AC_SUBST(NO_UNSETENV) +# # Define NO_MKDTEMP if you don't have mkdtemp in the C library. AC_CHECK_FUNC(mkdtemp, [NO_MKDTEMP=],
-- 1.5.3.7