git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] builtin-commit: fix amending of the initial commit

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 23, 2007, 03:55 UTC
Message-ID
<1198382136-15724-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1198382136-15724-1-git-send-email-gitster@pobox.com>

When amending initial commit without editor, the command incorrectly barfed because the check to see if there is anything to commit referenced the non-existent HEAD^1.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-commit.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 96410de..d8f0dfd 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -374,7 +374,7 @@ static int prepare_log_message(const char *index_file, const char *prefix)
 
 	if (no_edit) {
 		struct rev_info rev;
-		unsigned char sha1[40];
+		unsigned char sha1[20];
 		const char *parent = "HEAD";
 
 		fclose(fp);
@@ -382,12 +382,12 @@ static int prepare_log_message(const char *index_file, const char *prefix)
 		if (!active_nr && read_cache() < 0)
 			die("Cannot read index");
 
-		if (get_sha1("HEAD", sha1) != 0)
-			return !!active_nr;
-
 		if (amend)
 			parent = "HEAD^1";
 
+		if (get_sha1(parent, sha1))
+			return !!active_nr;
+
 		init_revisions(&rev, "");
 		rev.abbrev = 0;
 		setup_revisions(0, NULL, &rev, parent);
-- 
1.5.4.rc1.19.g9151fa
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 6 in “t7005: do not exit inside test.”
  1. 1/4 t7005: do not exit inside test.Junio C Hamano, Dec 23, 2007
  2. 2/4 builtin-commit: fix amending of the initial commitJunio C Hamano, Dec 23, 2007
  3. 3/4 builtin-commit: avoid double-negation in the code.Junio C Hamano, Dec 23, 2007
  4. 4/4 Allow selection of different cleanup modes for commit messagesJunio C Hamano, Dec 23, 2007
  5. Junio C HamanoDec 26, 2007
  6. Linus TorvaldsDec 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.