git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] t3903-stash.sh: Add missing '&&' to body of testcase

From
drafnel@gmail.com <drafnel@gmail.com>
Date
Mar 2, 2008, 20:58 UTC
Message-ID
<11977092.1204491503671.JavaMail.teamon@b308.teamon.com>
Signed-off-by: Brandon Casey <drafnel@gmail.com>
---

It looks like this was just forgotten. I can't think of any reason why you'd not want the echos and git-add to be part of the whole return value of the test.

-brandon
 t/t3903-stash.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 9a9a250..50a2c83 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -40,7 +40,7 @@ test_expect_success 'parents of stash' '
 test_expect_success 'apply needs clean working directory' '
 	echo 4 > other-file &&
 	git add other-file &&
-	echo 5 > other-file
+	echo 5 > other-file &&
 	! git stash apply
 '
 
-- 
1.5.4.3.412.gcd100
Message 1 of 1 in “t3903-stash.sh: Add missing '&&' to body of testcase”
  1. 1/4 t3903-stash.sh: Add missing '&&' to body of testcasedrafnel@gmail.com, Mar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.