git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui - Unconditionally use absolute paths with Cygwin

From
Mark Levedahl <mdl123@verizon.net>
Date
Dec 13, 2007, 14:02 UTC
Message-ID
<1197554546-2260-1-git-send-email-mdl123@verizon.net>

The mapping of Windows vs Cygwin/Posix paths is arbitrary and not knowable from the Posix side, so logic to determine whether to use relative paths to locate the git-gui library just does not work on Cygwin. Fix this to unconditionally use absolute path on Cygwin. (This fixes a regression from 1.5.4).

Signed-off-by: Mark Levedahl <mdl123@verizon.net>
---
 git-gui/Makefile |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index 26ac4b6..c109eab 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -117,14 +117,12 @@ GITGUI_SCRIPT   := $$0
 GITGUI_RELATIVE :=
 GITGUI_MACOSXAPP :=
 
-ifeq ($(exedir),$(gg_libdir))
-	GITGUI_RELATIVE := 1
-endif
-
 ifeq ($(uname_O),Cygwin)
 	GITGUI_SCRIPT := `cygpath --windows --absolute "$(GITGUI_SCRIPT)"`
-	ifeq ($(GITGUI_RELATIVE),)
-		gg_libdir := $(shell cygpath --windows --absolute "$(gg_libdir)")
+	gg_libdir := $(shell cygpath --windows --absolute "$(gg_libdir)")
+else
+	ifeq ($(exedir),$(gg_libdir))
+		GITGUI_RELATIVE := 1
 	endif
 endif
 ifeq ($(uname_S),Darwin)
-- 
1.5.3.7.1167.g12f9a
Message 1 of 1 in “git-gui - Unconditionally use absolute paths with Cygwin”
  1. git-gui - Unconditionally use absolute paths with CygwinMark Levedahl, Dec 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.