git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/2] diff whitespace tweaks

From
Wincent Colaiuta <win@wincent.com>
Date
Dec 12, 2007, 08:12 UTC
Message-ID
<1197447122-93416-1-git-send-email-win@wincent.com>
[1/2] Use "whitespace" consistently
This one is a simple consistency fix that should go on top of "master".
[2/2] "diff --check" should affect exit status

This one is why I put "RFC" in the subject line. Basically, when I discovered that "diff --check" didn't affect the exit status of the command I thought it might be a bug, in which case this fix or one like it should go in for 1.5.4. This patch also applies on top of "master".

But if you don't consider that to be a bug then I guess it's "next" or even "pu" material and I can bring it back up after 1.5.4 is out.

Another reason why I label this as "RFC" is that the diff machinery is fairly bulky and I was not familiar with it. So this patch is the result of someone who has looked at the source for half an hour and deduced enough to implement the desired behaviour; but somone who truly groks the diff code may be able to think of a nicer implementation.

Next: Wincent Colaiuta
Message 1 of 5 in “diff whitespace tweaks”
  1. 0/2 diff whitespace tweaksWincent Colaiuta, Dec 12, 2007
  2. 1/2 Use "whitespace" consistentlyWincent Colaiuta, Dec 12, 2007
  3. 2/2 "diff --check" should affect exit statusWincent Colaiuta, Dec 12, 2007
  4. Junio C HamanoDec 12, 2007
  5. Wincent ColaiutaDec 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.