git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Brown paper bag fix to previous send-email change

From
Mike Hommey <mh@glandium.org>
Date
Dec 11, 2007, 06:55 UTC
Message-ID
<1197356116-12176-1-git-send-email-mh@glandium.org>

My previous change led to the In-Reply-To header being <> when the given value was empty. This fixes it.

Signed-off-by: Mike Hommey <mh@glandium.org>
---
 I think I have an antispam problem somewhere with this patch, because even
 keeping sending it, it never reached the list. And Junio didn't answer to my
 private message about it, so I guess that was some server being smart with
 the subject line. *sigh*
 PS: sorry Junio if you get this patch multiple time.
 git-send-email.perl |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index c0e1dd3..0e8c457 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -369,8 +369,10 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 	$initial_reply_to = $_;
 }
 
-$initial_reply_to =~ s/^\s*<?/</;
-$initial_reply_to =~ s/>?\s*$/>/;
+if ($initial_reply_to) {
+	$initial_reply_to =~ s/^\s*<?/</;
+	$initial_reply_to =~ s/>?\s*$/>/;
+}
 
 if (!defined $smtp_server) {
 	foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
-- 
1.5.3.7.1161.g14b8
Next: Junio C Hamano
Message 1 of 5 in “Brown paper bag fix to previous send-email change”
  1. Brown paper bag fix to previous send-email changeMike Hommey, Dec 11, 2007
  2. Junio C HamanoDec 11, 2007
  3. Mike HommeyDec 11, 2007
  4. Junio C HamanoDec 11, 2007
  5. Junio C HamanoDec 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.