git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] builtin-commit fixes

From
Wincent Colaiuta <win@wincent.com>
Date
Dec 8, 2007, 11:38 UTC
Message-ID
<1197113889-16243-1-git-send-email-win@wincent.com>

A little series to bring built-in commit back in line with the behaviour as implemented by git-commit.sh and described in the documentation.

1/3 Allow --no-verify to bypass commit-msg hook
- git-commit.sh used to do this, but builtin-commit wasn't.
2/3 Documentation: fix --no-verify documentation for "git commit"
- The "git commit" man page should mention the commit-msg hook to
bring it in line with what's in the hook notes and in
Documentation/hooks.txt.
3/3 Fix commit-msg hook to allow editing
- Again, git-commit.sh allowed this, but builtin-commit wasn't
doing so.

I have manually tested these changes and they seem to work, but the fact that the test suite didn't break when the behaviour of "git commit" changed is indicative of a hole in the suite. I am not very familiar yet with the test machinery, but I am going to see if I can whip something up.

Cheers, Wincent

Next: Wincent Colaiuta
Message 1 of 8 in “builtin-commit fixes”
  1. 0/3 builtin-commit fixesWincent Colaiuta, Dec 8, 2007
  2. 1/3 Allow --no-verify to bypass commit-msg hookWincent Colaiuta, Dec 8, 2007
  3. 2/3 Documentation: fix --no-verify documentation for "git commit"Wincent Colaiuta, Dec 8, 2007
  4. 3/3 Fix commit-msg hook to allow editingWincent Colaiuta, Dec 8, 2007
  5. Junio C HamanoDec 9, 2007
  6. Wincent ColaiutaDec 9, 2007
  7. 4/4 Add tests for pre-commit and commit-msg hooksWincent Colaiuta, Dec 8, 2007
  8. Wincent ColaiutaDec 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.