[PATCH 1/2] mailmap: fix bogus for() loop that happened to be safe by accident
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 8, 2007, 01:32 UTC
- Message-ID
- <1197077573-14945-1-git-send-email-gitster@pobox.com>
The empty loop pretended to have an empty statement as its body by a phony indentation, but in fact was slurping the next statement into it.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- mailmap.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/mailmap.c b/mailmap.c index 8714167..f017255 100644 --- a/mailmap.c +++ b/mailmap.c @@ -42,9 +42,10 @@ int read_mailmap(struct path_list *map, const char *filename, char **repo_abbrev continue; if (right_bracket == left_bracket + 1) continue; - for (end_of_name = left_bracket; end_of_name != buffer - && isspace(end_of_name[-1]); end_of_name--) - /* keep on looking */ + for (end_of_name = left_bracket; + end_of_name != buffer && isspace(end_of_name[-1]); + end_of_name--) + ; /* keep on looking */ if (end_of_name == buffer) continue; name = xmalloc(end_of_name - buffer + 1);
-- 1.5.3.7-2182-g108b