[PATCH 0/3 v3] Implement git-svn info

From: David D. Kilzer <ddkilzer@kilzer.net>
Date: Nov 21, 2007, 19:57 UTC
Message-ID: <1195675039-26746-1-git-send-email-ddkilzer@kilzer.net>

Changes since the last patch series I posted (last night):

- Patch 1/3: No changes.
- Patch 2/3: Only changes to test code.
  - Renamed t/t9117-git-svn-info.sh to t/t9119-git-svn-info.sh.
  - Removed static expected.* files and reinstated dynamic generation.
  - Replaced "touch -c -r" with ptouch (portable/perl touch) function.
    (Should this go in t/lib-git-svn.sh?)
  - Use sed(1) inline to work around minor "svn info" vs. "git svn info"
    difference.
  - Minor test name and expected.*/actual.* file name changes.
  - Updated comments.
- Patch 3/3: Added 17 more tests (mirroring the existing 18 tests from
  Patch 2/3).

"David D. Kilzer" <ddkilzer@kilzer.net> wrote:

Show 11 quoted lines

> "David D. Kilzer" <ddkilzer@kilzer.net> wrote:
> > Eric Wong <normalperson@yhbt.net> wrote:
> > > Can we expect the output of "svn info" to not change between
> > > versions?  I know "svn status" has changed between versions of
> > > svn.  I'd prefer if we keep the expected.* files hard-coded
> > > in a test directory and compare those instead.  Maybe use sed
> > > to substitute placeholders for timestamps..
> > Done.
> Grrr.  I remember the reason I didn't do this in the first place.
> In Patch 2/3, there are now hard-coded directory paths and my
> username in the static expected-* files.

Actually, using "svn info" to dynamically generate the results means that the tests will break when "svn info" does change, which is a good thing. In other words, I think we want to know when that happens so that we can make a decision about whether to support the change or not.

Dave