[PATCH] Authenticate only once in git-send-email
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Nov 21, 2007, 12:35 UTC
- Message-ID
- <1195648505-21653-1-git-send-email-win@wincent.com>
When using git-send-email with SMTP authentication sending a patch series would redundantly authenticate multiple times, once for each patch. In the worst case, this would actually prevent the series from being sent because the server would reply with a "5.5.0 Already Authenticated" status code which would derail the process.
This commit teaches git-send-email to authenticate once and only once at the beginning of the series.
Signed-off-by: Wincent Colaiuta <win@wincent.com> --- git-send-email.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 9c6fa64..76baa8e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -145,6 +145,7 @@ sub format_2822_time { my $have_email_valid = eval { require Email::Valid; 1 }; my $smtp; +my $auth; sub unique_email_list(@); sub cleanup_compose_files(); @@ -635,7 +636,7 @@ X-Mailer: git-send-email $gitversion } if ((defined $smtp_authuser) && (defined $smtp_authpass)) { - $smtp->auth( $smtp_authuser, $smtp_authpass ) or die $smtp->message; + $auth ||= $smtp->auth( $smtp_authuser, $smtp_authpass ) or die $smtp->message; } $smtp->mail( $raw_from ) or die $smtp->message; $smtp->to( @recipients ) or die $smtp->message;
-- 1.5.3.5.737.gdee1b