git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin-commit: Fix git-commit honoring status.color

From
Ping Yin <pkufranky@gmail.com>
Date
Nov 18, 2007, 17:10 UTC
Message-ID
<1195405834-1469-1-git-send-email-pkufranky@gmail.com>
status.color shouldn't be honored when committing since the run-status
output is fed to the editor.
---
 builtin-commit.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 8db74ed..4396e7d 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -45,6 +45,7 @@ static int quiet, verbose, untracked_files, no_verify;
 static int no_edit, initial_commit, in_merge;
 const char *only_include_assumed;
 struct strbuf message;
+extern int wt_status_use_color;
 
 static int opt_parse_m(const struct option *opt, const char *arg, int unset)
 {
@@ -325,6 +326,7 @@ static int prepare_log_message(const char *index_file, const char *prefix)
 	if (only_include_assumed)
 		fprintf(fp, "# %s\n", only_include_assumed);
 
+	wt_status_use_color = 0;
 	commitable = run_status(fp, index_file, prefix);
 
 	fclose(fp);
-- 
1.5.3.5.1876.g7ba19-dirty
Next: Junio C Hamano
Message 1 of 4 in “builtin-commit: Fix git-commit honoring status.color”
  1. builtin-commit: Fix git-commit honoring status.colorPing Yin, Nov 18, 2007
  2. Junio C HamanoNov 18, 2007
  3. builtin-commit: run commit-msg hook with correct message fileJunio C Hamano, Nov 18, 2007
  4. Ping YinNov 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.