[PATCH] send-email: apply --suppress-from to S-o-b and cc-cmd
- From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
- Date
- Nov 7, 2007, 07:34 UTC
- Message-ID
- <1194420852-15822-1-git-send-email-ukleinek@informatik.uni-freiburg.de>
From: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com> Cc: Ryan Anderson <ryan@michonline.com> --- Hello,
I don't see the sense in adding the sender to Cc: from Signed-off-by lines but not from From:. If someone is convinced it makes sense, I'm willing to send a new patch that uses a different option.
Cc'd Ryan as the author of --suppress-from.
I already tried to send this from my work's email account, but it seems to have problems to send mails to vger (and lists.arm.linux.org.uk). Sorry Ryan if you get this mail once more.
Best regards Uwe
Documentation/git-send-email.txt | 3 +-- git-send-email.perl | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index e38b702..659215a 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -113,8 +113,7 @@ The --cc option must be repeated for each user you want on the cc list. is not set, this will be prompted for. --suppress-from, --no-suppress-from:: - If this is set, do not add the From: address to the cc: list, if it - shows up in a From: line. + If this is set, do not add the From: address to the cc: list. Default is the value of 'sendemail.suppressfrom' configuration value; if that is unspecified, default to --no-suppress-from. diff --git a/git-send-email.perl b/git-send-email.perl index 96051bc..f4b8f96 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -88,8 +88,7 @@ Options: --smtp-ssl If set, connects to the SMTP server using SSL. - --suppress-from Suppress sending emails to yourself if your address - appears in a From: line. Defaults to off. + --suppress-from Suppress sending emails to yourself. Defaults to off. --thread Specify that the "In-Reply-To:" header should be set on all emails. Defaults to on. @@ -730,6 +729,7 @@ foreach my $t (@files) { if (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc) { my $c = $2; chomp $c; + next if ($c eq $sender and $suppress_from); push @cc, $c; printf("(sob) Adding cc: %s from line '%s'\n", $c, $_) unless $quiet; @@ -745,6 +745,7 @@ foreach my $t (@files) { my $c = $_; $c =~ s/^\s*//g; $c =~ s/\n$//g; + next if ($c eq $sender and $suppress_from); push @cc, $c; printf("(cc-cmd) Adding cc: %s from: '%s'\n", $c, $cc_cmd) unless $quiet;
-- 1.5.3.4