git/list[1] front-page[2] threads[3] people[4] search[5] about
 

ph/parseopt-sh reloaded

From
Pierre Habouzit <madcoder@debian.org>
Date
Nov 4, 2007, 10:30 UTC
Message-ID
<1194172262-1563-1-git-send-email-madcoder@debian.org>

Okay here is a fixed series wrt the security issue Junio raised. Instead of the old PARSEOPT_OPTS variable, I now only have OPTIONS_KEEPDASHDASH to be set to non empty if you want to add --keep-dashdash. The reason for that is that I dislike that every single git-rev-parse --parseopt user had to do a `PASREOPT_OPTS=` at the begining of each script, it's error prone, and ugly.

PARSEOPT_OPTS was an overkill as it wasn't really used for anything else than OPTIONS_KEEPDASHDASH, and if it has to be used for more, it'll be easy to extend the specification parser to take options on stdin rather than through parameters.

I also removed the PARSEOPT_OPTS from git-clone.sh as it was a spurious use, I don't intend users to override this variable, it's indeed an internal that changes git-rev-parse --parseopt behaviour in a incompatible way for the scripts that uses it, it should not be user-tweakable anyway.

The 10 patch series (and not 11, I forgot about 7 when I incrementally sent the previous one) is fetcheable from my repository:

  git://git.madism.org/git.git on branch ph/parseopt-sh

(ph/parseopt has the remaining patches that are problematic right now either because of the small change -h vs. -H or the patches that conflicts with git-fetch series right now, but in the spirit this is definitely a ph/parseopt series).

Cheers,
Next: Pierre Habouzit
Message 1 of 20 in “ph/parseopt-sh reloaded”
  1. Pierre HabouzitNov 4, 2007
  2. 01/10 Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.Pierre Habouzit, Nov 4, 2007
  3. 02/10 Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  4. 03/10 Migrate git-clean.sh to use git-rev-parse --parseopt.Pierre Habouzit, Nov 4, 2007
  5. 04/10 Migrate git-clone to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  6. 05/10 Migrate git-am.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  7. 06/10 Migrate git-merge.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  8. 07/10 Migrate git-instaweb.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  9. 08/10 Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdashPierre Habouzit, Nov 4, 2007
  10. 09/10 Migrate git-quiltimport.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  11. 10/10 Migrate git-repack.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  12. Pierre HabouzitNov 4, 2007
  13. Nicolas PitreNov 6, 2007
  14. Junio C HamanoNov 6, 2007
  15. Nicolas PitreNov 6, 2007
  16. Junio C HamanoNov 6, 2007
  17. Ralf WildenhuesNov 4, 2007
  18. Ralf WildenhuesNov 4, 2007
  19. Junio C HamanoNov 4, 2007
  20. Pierre HabouzitNov 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.