git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] pack-objects: no delta possible with only one object in the list

From
Nicolas Pitre <nico@cam.org>
Date
Oct 17, 2007, 01:55 UTC
Message-ID
<1192586150-13743-4-git-send-email-nico@cam.org>
In-Reply-To
<1192586150-13743-3-git-send-email-nico@cam.org>

... so don't even try in that case, and save another useless line of progress display.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---
 builtin-pack-objects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index df69abd..d729cb7 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -1714,7 +1714,7 @@ static void prepare_pack(int window, int depth)
 		delta_list[n++] = entry;
 	}
 
-	if (nr_deltas) {
+	if (nr_deltas && n > 1) {
 		unsigned nr_done = 0;
 		if (progress)
 			start_progress(&progress_state, "Deltifying objects",
-- 
1.5.3.4.1212.gdb015
Previous: Nicolas PitreNext: Nicolas Pitre
Message 4 of 17 in “miscelaneous stuff”
  1. 0/6 miscelaneous stuffNicolas Pitre, Oct 17, 2007
  2. 1/6 more compact progress displayNicolas Pitre, Oct 17, 2007
  3. 2/6 cope with multiple line breaks within sideband progress messagesNicolas Pitre, Oct 17, 2007
  4. 3/6 pack-objects: no delta possible with only one object in the listNicolas Pitre, Oct 17, 2007
  5. 4/6 pack-objects.c: fix some global variable abuse and memory leaksNicolas Pitre, Oct 17, 2007
  6. 5/6 fix const issues with some functionsNicolas Pitre, Oct 17, 2007
  7. 6/6 fix for more minor memory leaksNicolas Pitre, Oct 17, 2007
  8. Deltifying? (was [PATCH 3/6] pack-objects: no delta possible...)Shawn O. Pearce, Oct 17, 2007
  9. Nicolas PitreOct 17, 2007
  10. Shawn O. PearceOct 17, 2007
  11. Nicolas PitreOct 17, 2007
  12. Karl HasselströmOct 17, 2007
  13. Nicolas PitreOct 17, 2007
  14. Shawn O. PearceOct 18, 2007
  15. Karl HasselströmOct 18, 2007
  16. Johannes SixtOct 17, 2007
  17. Shawn O. PearceOct 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.