Re: [PATCH] post-checkout hook, and related docs and tests
On Tue, 2007-09-25 at 14:29 -0700, Junio C Hamano wrote:
Show 15 quoted lines
> "Josh England" <jjengla@sandia.gov> writes:
>
> > So this leads to my next question: Should the post-merge patch be
> > brought in under this same umbrella to form a single post-checkout hook,
> > or should it stay a separate hook?
>
> I think it is called would be inconvenient for the callee if you
> call the same hook without telling the hook script why it is
> called, so if you go in the unification route the caller of the
> unified hook needs to supply an extra parameter and existing
> hooks if any need to be updated --- neither sounds like a very
> idea. The writer of the hooks however can choose to call one
> from the other if he wants the same action for both hooks, so it
> looks to me that separate hooks for separate purposes is the way
> to go.
Yeah, I agree. I'll rework post-checkout and send in both again.
-JE