Re: [PATCH] Move option parsing code to parse-options.[ch].

From: Kristian Høgsberg <krh@redhat.com>
Date: Sep 24, 2007, 18:41 UTC
Message-ID: <1190659262.10444.1.camel@hinata.boston.redhat.com>
In-Reply-To: <7vsl57iz1t.fsf@gitster.siamese.dyndns.org>

On Fri, 2007-09-21 at 12:44 -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Kristian Høgsberg <krh@redhat.com> writes:
> 
> > Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> > ---
> >  Makefile         |    2 +-
> >  builtin-commit.c |  117 ++++++++----------------------------------------------
> >  parse-options.c  |   74 ++++++++++++++++++++++++++++++++++
> >  parse-options.h  |   29 +++++++++++++
> >  4 files changed, 121 insertions(+), 101 deletions(-)
> >  create mode 100644 parse-options.c
> >  create mode 100644 parse-options.h
> 
> Hmmmmmmm. Is it too much to ask to pretend as if the previous
> "builtin-commit.c" that had these parts that did not belong to
> it in the first place never happened?

No problem, I wasn't sure whether to update the patches or to just send follow-up patches now that it was in pu. I'll resend 7/7 as 3 new patches that exports add_files_to_cache(), adds option parsing, and finally builtin-commit.

Kristian