git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] git-merge: fix faulty SQUASH_MSG

From
LHLars Hjemli <hjemli@gmail.com>
Date
Sep 23, 2007, 22:51 UTC
Message-ID
<1190587905-700-3-git-send-email-hjemli@gmail.com>
In-Reply-To
<1190587905-700-2-git-send-email-hjemli@gmail.com>

Only the first 'remote' head is currently specified as an argument to 'git log' when generating a SQUSH_MSG, which makes the generated message fail to mention every commit involved in the merge. This fixes the problem.

Noticed-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---
 git-merge.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-merge.sh b/git-merge.sh
index 3a01db0..3857634 100755
--- a/git-merge.sh
+++ b/git-merge.sh
@@ -59,7 +59,7 @@ finish_up_to_date () {
 squash_message () {
 	echo Squashed commit of the following:
 	echo
-	git log --no-merges ^"$head" $remote
+	git log --no-merges ^"$head" $remoteheads
 }
 
 finish () {
-- 
1.5.3.2.82.g75c8d
Previous: Lars HjemliNext: Lars Hjemli
Message 3 of 7 in “per branch options for git-merge”
  1. 0/6 per branch options for git-mergeLars Hjemli, Sep 23, 2007
  2. 1/6 Add test-script for git-merge porcelainLars Hjemli, Sep 23, 2007
  3. 2/6 git-merge: fix faulty SQUASH_MSGLars Hjemli, Sep 23, 2007
  4. 3/6 git-merge: refactor option parsingLars Hjemli, Sep 23, 2007
  5. 4/6 git-merge: add support for branch.<name>.mergeoptionsLars Hjemli, Sep 23, 2007
  6. 5/6 git-merge: add support for --commit and --no-squashLars Hjemli, Sep 23, 2007
  7. 6/6 git-merge: add --ff and --no-ff optionsLars Hjemli, Sep 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.