git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Latest builtin-commit series

From
Kristian Høgsberg <krh@redhat.com>
Date
Sep 18, 2007, 15:23 UTC
Message-ID
<1190129009.23692.24.camel@hinata.boston.redhat.com>
Hi,

I sent out a new builtin-commit patch series last night, and figured I should have written a cover letter to describe the changes there. Better late than never:

      * rebase to Pierres strbuf changes.  Note, there is still some
        strbuf tweaking required, to let stripspace work on a strbuf.
        Also, I changed the semantics of stripspace to always add a
        newline if the last line doesn't have one.  I believe the
        current odd semantics (always remove the last newline) comes
        from not being able to easily add a newline, but now that it's a
        strbuf, that's easy.
      * Fixing the last bug that caused trouble in the test suite: even
        if run_status says there's nothing to commit, proceed if we're
        doing a merge.
      * Set the test suite default editor to '/bin/true' instead of ':'.
        Since we're not exec'ing the editor from shell anymore, ':'
        won't work.  Maybe we should special case ':' in launch_editor
        or perhaps make launch_editor use system(3).  Not sure.
      * The first few patches are good to go, and if we can get them
        committed to next, we can focus on the builtin-commit patch.
        Specifically:
                0001-Enable-wt-status-output-to-a-given-FILE-pointer.patch
                0002-Enable-wt-status-to-run-against-non-standard-index-f.patch
                0003-Introduce-entry-point-for-launching-add-interactive.patch
                0004-Clean-up-stripspace-a-bit-use-strbuf-even-more.patch
                0005-Add-strbuf_read_file.patch
                0006-Export-rerere-and-launch_editor.patch
                        (edit our "and launch_editor" from the title)
                
        should all be fine and easy to review, whereas 
        
                0007-Implement-git-commit-as-a-builtin-command.patch
                
        will probably need some careful reviewing.  That said, it is
        feature complete, the code is nice enough and it passes the test
        suite.  It's just a very important part of git :)

cheers, Kristian

(sorry about the duplicate mail)
Next: Alex Riesen
Message 1 of 7 in “Latest builtin-commit series”
  1. Kristian HøgsbergSep 18, 2007
  2. Alex RiesenSep 18, 2007
  3. Johannes SchindelinSep 18, 2007
  4. Junio C HamanoSep 18, 2007
  5. Kristian HøgsbergSep 18, 2007
  6. Pierre HabouzitSep 18, 2007
  7. Junio C HamanoSep 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.