Latest builtin-commit series
- From
Kristian Høgsberg <krh@redhat.com>
- Date
- Sep 18, 2007, 15:23 UTC
- Message-ID
- <1190129009.23692.24.camel@hinata.boston.redhat.com>
Hi,
I sent out a new builtin-commit patch series last night, and figured I should have written a cover letter to describe the changes there. Better late than never:
* rebase to Pierres strbuf changes. Note, there is still some
strbuf tweaking required, to let stripspace work on a strbuf.
Also, I changed the semantics of stripspace to always add a
newline if the last line doesn't have one. I believe the
current odd semantics (always remove the last newline) comes
from not being able to easily add a newline, but now that it's a
strbuf, that's easy. * Fixing the last bug that caused trouble in the test suite: even
if run_status says there's nothing to commit, proceed if we're
doing a merge. * Set the test suite default editor to '/bin/true' instead of ':'.
Since we're not exec'ing the editor from shell anymore, ':'
won't work. Maybe we should special case ':' in launch_editor
or perhaps make launch_editor use system(3). Not sure. * The first few patches are good to go, and if we can get them
committed to next, we can focus on the builtin-commit patch.
Specifically: 0001-Enable-wt-status-output-to-a-given-FILE-pointer.patch
0002-Enable-wt-status-to-run-against-non-standard-index-f.patch
0003-Introduce-entry-point-for-launching-add-interactive.patch
0004-Clean-up-stripspace-a-bit-use-strbuf-even-more.patch
0005-Add-strbuf_read_file.patch
0006-Export-rerere-and-launch_editor.patch
(edit our "and launch_editor" from the title)
should all be fine and easy to review, whereas
0007-Implement-git-commit-as-a-builtin-command.patch
will probably need some careful reviewing. That said, it is
feature complete, the code is nice enough and it passes the test
suite. It's just a very important part of git :)cheers, Kristian
(sorry about the duplicate mail)