Re: git-annotate efficiency

From: Morten Welinder <mwelinder@gmail.com>
Date: Feb 24, 2006, 18:00 UTC
Message-ID: <118833cc0602241000p4e4c8017u3e3afe76fbbd75a4@mail.gmail.com>
In-Reply-To: <118833cc0602240737i42acdc90sb8f93dde1a1bc035@mail.gmail.com>

It looks like handle_rev is seeing the same revisions over and over again. I don't know why that would be, but the following patch just skips dups. I have no idea if it is right, though.

Morten

diff --git a/git-annotate.perl b/git-annotate.perl
index 3800c46..a5e2d86 100755
--- a/git-annotate.perl
+++ b/git-annotate.perl
@@ -117,7 +117,10 @@ sub init_claim {

 sub handle_rev {
        my $i = 0;
+       my %seen = ();
        while (my $rev = shift @revqueue) {
+               next if $seen{$rev};
+               $seen{$rev} = 1;

                my %revinfo = git_commit_info($rev);