git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH 3/6] Don't touch state after conflict in push

From
David Kågedal <davidk@lysator.liu.se>
Date
Aug 20, 2007, 08:12 UTC
Message-ID
<11875975232606-git-send-email-davidk@lysator.liu.se>
In-Reply-To
<11875975232734-git-send-email-davidk@lysator.liu.se>
From: David KÃ¥gedal <davidk@lysator.liu.se>

This leaves the index and working tree in the state that merge-recursive left it, with unmerged files in different stages, and the non-conflicting changes in the index.

Signed-off-by: David KÃ¥gedal <davidk@lysator.liu.se>
---
 stgit/stack.py |   17 ++++++++++++-----
 1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/stgit/stack.py b/stgit/stack.py
index 8b77943..0e43f75 100644
--- a/stgit/stack.py
+++ b/stgit/stack.py
@@ -728,6 +728,7 @@ class Series(PatchSet):
         config.unset(self.format_version_key())
 
     def refresh_patch(self, files = None, message = None, edit = False,
+                      empty = False,
                       show_patch = False,
                       cache_update = True,
                       author_name = None, author_email = None,
@@ -777,9 +778,16 @@ class Series(PatchSet):
 
         bottom = patch.get_bottom()
 
+        if empty:
+            tree_id = git.get_commit(bottom).get_tree()
+        else:
+            tree_id = None
+
         commit_id = git.commit(files = files,
                                message = descr, parents = [bottom],
                                cache_update = cache_update,
+                               tree_id = tree_id,
+                               set_head = True,
                                allowempty = True,
                                author_name = author_name,
                                author_email = author_email,
@@ -1083,11 +1091,10 @@ class Series(PatchSet):
                     log = 'push'
                 self.refresh_patch(cache_update = False, log = log)
             else:
-                # we store the correctly merged files only for
-                # tracking the conflict history. Note that the
-                # git.merge() operations should always leave the index
-                # in a valid state (i.e. only stage 0 files)
-                self.refresh_patch(cache_update = False, log = 'push(c)')
+                # we make the patch empty, with the merged state in
+                # the working tree.
+                self.refresh_patch(cache_update = False, empty = True,
+                                   log = 'push(c)')
                 raise StackException, str(ex)
 
         return modified
-- 
1.5.3.rc3.119.g1812
Previous: David KågedalNext: David Kågedal
Message 4 of 18 in “Use git conflict handling on push”
  1. 0/6 Use git conflict handling on pushDavid Kågedal, Aug 20, 2007
  2. 1/6 Split git.merge into two functionsDavid Kågedal, Aug 20, 2007
  3. 2/6 Don't try to merge files that merge-recursive already mergedDavid Kågedal, Aug 20, 2007
  4. 3/6 Don't touch state after conflict in pushDavid Kågedal, Aug 20, 2007
  5. 4/6 Added a test case to check what happens when push finds a conflictDavid Kågedal, Aug 20, 2007
  6. 5/6 Simplify merge_recursiveDavid Kågedal, Aug 20, 2007
  7. 6/6 Use the output from merge-recursive to list conflictsDavid Kågedal, Aug 20, 2007
  8. Karl HasselströmAug 22, 2007
  9. David KågedalAug 22, 2007
  10. Karl HasselströmAug 22, 2007
  11. Karl HasselströmAug 22, 2007
  12. Leave working dir and index alone after failed (conflicting) pushKarl Hasselström, Aug 22, 2007
  13. David KågedalAug 20, 2007
  14. Junio C HamanoAug 20, 2007
  15. Uwe Kleine-KönigAug 21, 2007
  16. Junio C HamanoAug 22, 2007
  17. Karl HasselströmAug 22, 2007
  18. Catalin MarinasAug 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.