git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] send-email: rfc822 forbids using <address@domain> without a non-empty "phrase"

From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date
Aug 9, 2007, 13:27 UTC
Message-ID
<1186666080946-git-send-email-ukleinek@informatik.uni-freiburg.de>
In-Reply-To
<11866660781833-git-send-email-ukleinek@informatik.uni-freiburg.de>

Email::Valid does respect this considering such a mailbox specification invalid. b06c6bc831cbb9e9eb82fd3ffd5a2b674cd940d0 addressed the issue, but only if Email::Valid is available.

Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 39e433b..a02ab96 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -408,8 +408,8 @@ sub extract_valid_address {
 	# check for a local address:
 	return $address if ($address =~ /^($local_part_regexp)$/);
 
+	$address =~ s/^\s*<(.*)>\s*$/$1/;
 	if ($have_email_valid) {
-		$address =~ s/^\s*<(.*)>\s*$/$1/;
 		return scalar Email::Valid->address($address);
 	} else {
 		# less robust/correct than the monster regexp in Email::Valid,
-- 
1.5.3.rc3.943.g14c81
Previous: Uwe Kleine-KönigNext: Uwe Kleine-König
Message 2 of 3 in “patches for send-email”
  1. 0/2 patches for send-emailUwe Kleine-König, Aug 9, 2007
  2. 1/2 send-email: rfc822 forbids using <address@domain> without a non-empty "phrase"Uwe Kleine-König, Aug 9, 2007
  3. 2/2 send-email: get all the quoting of realnames rightUwe Kleine-König, Aug 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.