git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] send-email: don't add sender to Cc: if --suppress-from is given.

From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date
Aug 7, 2007, 13:12 UTC
Message-ID
<1186492357499-git-send-email-ukleinek@informatik.uni-freiburg.de>

Up to now the sender is added to the Cc: list for Signed-off-by and Cc lines even if --suppress-from is requested.

Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
---
Hello,

Maybe the address should be added for a Cc: line, but not for Signed-off-by?

Best regards Uwe

 git-send-email.perl |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 39e433b..9d7f6a8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -646,9 +646,11 @@ foreach my $t (@files) {
 			if (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc) {
 				my $c = $2;
 				chomp $c;
-				push @cc, $c;
-				printf("(sob) Adding cc: %s from line '%s'\n",
-					$c, $_) unless $quiet;
+				if (not $suppress_from or unquote_rfc2047($c) eq $from) {
+					push @cc, $c;
+					printf("(sob) Adding cc: %s from line '%s'\n",
+						$c, $_) unless $quiet;
+				}
 			}
 		}
 	}
-- 
1.5.3.rc3.13.g7ab3
Message 1 of 1 in “send-email: don't add sender to Cc: if --suppress-from is given.”
  1. send-email: don't add sender to Cc: if --suppress-from is given.Uwe Kleine-König, Aug 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.